Bug 208462 - Fix for LayoutTests/accessibility/mac/value-change/value-change-user-info-contenteditable.html in IsolatedTree mode.
Summary: Fix for LayoutTests/accessibility/mac/value-change/value-change-user-info-con...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andres Gonzalez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-02 12:29 PST by Andres Gonzalez
Modified: 2020-03-08 12:08 PDT (History)
12 users (show)

See Also:

Attachments
Patch (20.88 KB, patch)
2020-03-02 13:05 PST, Andres Gonzalez 		no flags Details | Formatted Diff | Diff
Patch (21.14 KB, patch)
2020-03-02 18:51 PST, Andres Gonzalez 		no flags Details | Formatted Diff | Diff
Patch (21.11 KB, patch)
2020-03-08 10:48 PDT, Andres Gonzalez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andres Gonzalez 2020-03-02 12:29:43 PST 
Fix for LayoutTests/accessibility/mac/value-change/value-change-user-info-contenteditable.html in IsolatedTree mode.
Comment 1 Andres Gonzalez 2020-03-02 13:05:27 PST 
Created attachment 392177 [details]
Patch
Comment 2 Andres Gonzalez 2020-03-02 18:51:02 PST 
Created attachment 392240 [details]
Patch
Comment 3 WebKit Commit Bot 2020-03-02 20:07:47 PST 
Comment on attachment 392240 [details]
Patch

Clearing flags on attachment: 392240

Committed r257760: <https://trac.webkit.org/changeset/257760>
Comment 4 WebKit Commit Bot 2020-03-02 20:07:49 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2020-03-02 20:08:18 PST 
<rdar://problem/59980673>
Comment 6 Jason Lawrence 2020-03-06 12:40:51 PST 
Reverted r257760 for reason:

This commit caused flaky crashing on Mac wk2.

Committed r258019: <https://trac.webkit.org/changeset/258019>
Comment 7 Simon Fraser (smfr) 2020-03-07 10:21:28 PST 
Several tests are crashing after this rollout:
https://build.webkit.org/results/Apple%20Mojave%20Debug%20WK2%20(Tests)/r258071%20(8028)/results.html
Comment 8 Andres Gonzalez 2020-03-08 10:48:57 PDT 
Created attachment 392959 [details]
Patch
Comment 9 Andres Gonzalez 2020-03-08 10:55:23 PDT 
The cause of test failures is not directly related to this patch and is addressed with a new patch for bug:
https://bugs.webkit.org/show_bug.cgi?id=208648
Re-applying this patch.
Comment 10 WebKit Commit Bot 2020-03-08 12:08:17 PDT 
Comment on attachment 392959 [details]
Patch

Clearing flags on attachment: 392959

Committed r258108: <https://trac.webkit.org/changeset/258108>
Comment 11 WebKit Commit Bot 2020-03-08 12:08:19 PDT 
All reviewed patches have been landed.  Closing bug.