Bug 208458

Summary: Web Inspector: Remove old raster icons for object types and resources
Product: WebKit Reporter: Jon Davis <jond>
Component: Web InspectorAssignee: Jon Davis <jond>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, ews-watchlist, glenn, hi, inspector-bugzilla-changes, jer.noble, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 209433, 209434    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Jon Davis
Reported 2020-03-02 11:22:09 PST
The old PNG files can be removed now that SVG alternatives are in place.
Attachments
Patch (302.87 KB, patch)
2020-03-02 11:26 PST, Jon Davis 		no flags
DetailsFormatted DiffDiff
Patch (302.91 KB, patch)
2020-03-02 11:42 PST, Jon Davis 		no flags
DetailsFormatted DiffDiff
Patch (302.85 KB, patch)
2020-03-03 10:23 PST, Jon Davis 		no flags
DetailsFormatted DiffDiff
Patch (302.84 KB, patch)
2020-03-03 10:26 PST, Jon Davis 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Jon Davis
Comment 1 2020-03-02 11:26:40 PST
Created attachment 392164 [details] Patch
Jon Davis
Comment 2 2020-03-02 11:42:19 PST
Created attachment 392165 [details] Patch
Devin Rousso
Comment 3 2020-03-02 18:01:57 PST
Comment on attachment 392165 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=392165&action=review r=me, but please wait till <https://webkit.org/b/208453> is landed as current ToT still uses some of these icons > Source/WebInspectorUI/ChangeLog:83 > + * UserInterface/Images/Function.svg: Removed. This is still used by `WI.ThreadTreeElement`. > Source/WebInspectorUI/ChangeLog:89 > + * UserInterface/Images/HeapSnapshotSelected.svg: Removed. This is still used by `WI.HeapAllocationsTimelineOverviewGraph`. > Source/WebInspectorUI/ChangeLog:98 > + * UserInterface/Images/NavigationItemNetworkOverride.svg: This isn't in this patch. > Source/WebInspectorUI/ChangeLog:117 > + * UserInterface/Images/Thread.svg: Removed. This is still used by `WI.ThreadTreeElement`. > Source/WebInspectorUI/ChangeLog:137 > + * UserInterface/Images/TypeObject.svg: Removed. This is still used by `WI.SourcesNavigationSidebarPanel`.
Jon Davis
Comment 4 2020-03-03 10:23:10 PST
Created attachment 392292 [details] Patch
Jon Davis
Comment 5 2020-03-03 10:26:37 PST
Created attachment 392294 [details] Patch
WebKit Commit Bot
Comment 6 2020-03-03 11:41:53 PST
Comment on attachment 392294 [details] Patch Clearing flags on attachment: 392294 Committed r257791: <https://trac.webkit.org/changeset/257791>
WebKit Commit Bot
Comment 7 2020-03-03 11:41:54 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2020-03-03 11:42:16 PST
<rdar://problem/60005915>
Note You need to log in before you can comment on or make changes to this bug.