Bug 208453 - Web Inspector: Update breakpoint and search type icons
Summary: Web Inspector: Update breakpoint and search type icons
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Jon Davis
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-03-02 10:04 PST by Jon Davis
Modified: 2020-03-02 19:04 PST (History)
5 users (show)

See Also:

Attachments
Patch (125.72 KB, patch)
2020-03-02 11:16 PST, Jon Davis 		no flags Details | Formatted Diff | Diff
Sources tab in dark mode (1.19 MB, image/png)
2020-03-02 15:56 PST, Jon Davis 		no flags Details
Sources tab in light mode (1.21 MB, image/png)
2020-03-02 15:57 PST, Jon Davis 		no flags Details
Search tab in light mode (1.15 MB, image/png)
2020-03-02 15:59 PST, Jon Davis 		no flags Details
Search tab in dark mode (1.15 MB, image/png)
2020-03-02 15:59 PST, Jon Davis 		no flags Details
Patch (125.72 KB, patch)
2020-03-02 18:00 PST, Jon Davis 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jon Davis 2020-03-02 10:04:14 PST 
Replace raster icons with SVG for breakpoint and search icons.
Comment 1 Jon Davis 2020-03-02 11:16:33 PST 
Created attachment 392158 [details]
Patch
Comment 2 Jon Davis 2020-03-02 15:56:06 PST 
Created attachment 392203 [details]
Sources tab in dark mode
Comment 3 Jon Davis 2020-03-02 15:57:08 PST 
Created attachment 392204 [details]
Sources tab in light mode
Comment 4 Jon Davis 2020-03-02 15:59:23 PST 
Created attachment 392205 [details]
Search tab in light mode
Comment 5 Jon Davis 2020-03-02 15:59:47 PST 
Created attachment 392206 [details]
Search tab in dark mode
Comment 6 Nikita Vasilyev 2020-03-02 16:11:28 PST 
(In reply to Jon Davis from comment #4)
> Created attachment 392205 [details]
> Search tab in light mode

Off-topic: the window title text is white! Could you please file a bug and include your macOS, Safari, and WebKit version?
Comment 7 Jon Davis 2020-03-02 16:50:10 PST 
(In reply to Nikita Vasilyev from comment #6)
> (In reply to Jon Davis from comment #4)
> > Created attachment 392205 [details]
> > Search tab in light mode
> 
> Off-topic: the window title text is white! Could you please file a bug and
> include your macOS, Safari, and WebKit version?

That seems to be a bug with the Appearance setting in Web Inspector.
Comment 8 Devin Rousso 2020-03-02 17:38:27 PST 
Comment on attachment 392158 [details]
Patch

r=me

Would it be possible to make the icon used for JavaScript breakpoints use the same icon as the search result (e.g. make only the middle of the three lines white, and have the other two be darker)?
Comment 9 Jon Davis 2020-03-02 18:00:22 PST 
Created attachment 392232 [details]
Patch
Comment 10 WebKit Commit Bot 2020-03-02 19:03:52 PST 
Comment on attachment 392232 [details]
Patch

Clearing flags on attachment: 392232

Committed r257757: <https://trac.webkit.org/changeset/257757>
Comment 11 WebKit Commit Bot 2020-03-02 19:03:54 PST 
All reviewed patches have been landed.  Closing bug.
Comment 12 Radar WebKit Bug Importer 2020-03-02 19:04:21 PST 
<rdar://problem/59979284>