Bug 208453

Summary:

Web Inspector: Update breakpoint and search type icons

Product:

WebKit

Reporter:

Jon Davis <jond>

Component:

Web Inspector

Assignee:

Jon Davis <jond>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, hi, inspector-bugzilla-changes, nvasilyev, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Sources tab in dark mode	none
Sources tab in light mode	none
Search tab in light mode	none
Search tab in dark mode	none
Patch	none

Jon Davis

Reported 2020-03-02 10:04:14 PST

Replace raster icons with SVG for breakpoint and search icons.

Attachments
Patch (125.72 KB, patch) 2020-03-02 11:16 PST, Jon Davis	no flags	Details Formatted Diff Diff
Sources tab in dark mode (1.19 MB, image/png) 2020-03-02 15:56 PST, Jon Davis	no flags	Details
Sources tab in light mode (1.21 MB, image/png) 2020-03-02 15:57 PST, Jon Davis	no flags	Details
Search tab in light mode (1.15 MB, image/png) 2020-03-02 15:59 PST, Jon Davis	no flags	Details
Search tab in dark mode (1.15 MB, image/png) 2020-03-02 15:59 PST, Jon Davis	no flags	Details
Patch (125.72 KB, patch) 2020-03-02 18:00 PST, Jon Davis	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Jon Davis

Comment 1 2020-03-02 11:16:33 PST

Created attachment 392158 [details] Patch

Jon Davis

Comment 2 2020-03-02 15:56:06 PST

Created attachment 392203 [details] Sources tab in dark mode

Jon Davis

Comment 3 2020-03-02 15:57:08 PST

Created attachment 392204 [details] Sources tab in light mode

Jon Davis

Comment 4 2020-03-02 15:59:23 PST

Created attachment 392205 [details] Search tab in light mode

Jon Davis

Comment 5 2020-03-02 15:59:47 PST

Created attachment 392206 [details] Search tab in dark mode

Nikita Vasilyev

Comment 6 2020-03-02 16:11:28 PST

(In reply to Jon Davis from comment #4) > Created attachment 392205 [details] > Search tab in light mode Off-topic: the window title text is white! Could you please file a bug and include your macOS, Safari, and WebKit version?

Jon Davis

Comment 7 2020-03-02 16:50:10 PST

(In reply to Nikita Vasilyev from comment #6) > (In reply to Jon Davis from comment #4) > > Created attachment 392205 [details] > > Search tab in light mode > > Off-topic: the window title text is white! Could you please file a bug and > include your macOS, Safari, and WebKit version? That seems to be a bug with the Appearance setting in Web Inspector.

Devin Rousso

Comment 8 2020-03-02 17:38:27 PST

Comment on attachment 392158 [details] Patch r=me Would it be possible to make the icon used for JavaScript breakpoints use the same icon as the search result (e.g. make only the middle of the three lines white, and have the other two be darker)?

Jon Davis

Comment 9 2020-03-02 18:00:22 PST

Created attachment 392232 [details] Patch

WebKit Commit Bot

Comment 10 2020-03-02 19:03:52 PST

Comment on attachment 392232 [details] Patch Clearing flags on attachment: 392232 Committed r257757: <https://trac.webkit.org/changeset/257757>

WebKit Commit Bot

Comment 11 2020-03-02 19:03:54 PST

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 12 2020-03-02 19:04:21 PST

<rdar://problem/59979284>

Note You need to log in before you can comment on or make changes to this bug.