Bug 208417

Summary:

Simplify gradient parsing

Product:

WebKit

Reporter:

Darin Adler <darin>

Component:

CSS

Assignee:

Darin Adler <darin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, cdumez, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, macpherson, menard, mifenton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

Darin Adler

Reported 2020-02-29 14:15:39 PST

Simplify gradient parsing code

Attachments
Patch (72.46 KB, patch) 2020-02-29 15:03 PST, Darin Adler	no flags	Details Formatted Diff Diff
Patch (72.66 KB, patch) 2020-03-01 16:38 PST, Darin Adler	no flags	Details Formatted Diff Diff
Patch (72.77 KB, patch) 2020-03-01 18:56 PST, Darin Adler	no flags	Details Formatted Diff Diff
Patch (73.74 KB, patch) 2020-03-03 09:12 PST, Darin Adler	no flags	Details Formatted Diff Diff
Patch (73.74 KB, patch) 2020-03-04 21:00 PST, Darin Adler	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Darin Adler

Comment 1 2020-02-29 15:03:16 PST

Created attachment 392073 [details] Patch

Anders Carlsson

Comment 2 2020-02-29 15:12:49 PST

Comment on attachment 392073 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=392073&action=review > Source/WebCore/ChangeLog:8 > + - Use Optional<> and invalid Color to reprsent unspecified positions and colors. Typo "reprsent".

Darin Adler

Comment 3 2020-03-01 16:38:37 PST

Created attachment 392108 [details] Patch

Darin Adler

Comment 4 2020-03-01 16:39:24 PST

I’ll land this after EWS confirms I fixed the "use after move" mistake in my earlier patch that was screwing up parsing some gradients.

Darin Adler

Comment 5 2020-03-01 18:56:24 PST

Created attachment 392115 [details] Patch

Darin Adler

Comment 6 2020-03-03 09:12:22 PST

Created attachment 392283 [details] Patch