Bug 208409

Summary: The patch added in bug 138420 was dropped during updating gtest
Product: WebKit Reporter: Ting-Wei Lan <lantw44>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, mcatanzaro, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=138420
Attachments:
Description Flags
Patch for gtest
none
Patch for gtest none

Ting-Wei Lan
Reported 2020-02-29 01:24:49 PST
Without the patch, gtest can't be built on FreeBSD with -Wl,--no-undefined because of its use of 'environ' variable. I will attach a patch to re-add it.
Attachments
Patch for gtest (2.73 KB, patch)
2020-02-29 01:26 PST, Ting-Wei Lan 		no flags
DetailsFormatted DiffDiff
Patch for gtest (5.27 KB, patch)
2020-02-29 20:06 PST, Ting-Wei Lan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ting-Wei Lan
Comment 1 2020-02-29 01:26:27 PST
Created attachment 392053 [details] Patch for gtest
Michael Catanzaro
Comment 2 2020-02-29 14:39:20 PST
Comment on attachment 392053 [details] Patch for gtest Can you please add a README.webkit and a changes.diff (patch file) to document the changes? Otherwise it's just going to be lost again next update.
Ting-Wei Lan
Comment 3 2020-02-29 20:06:44 PST
Created attachment 392090 [details] Patch for gtest
WebKit Commit Bot
Comment 4 2020-03-01 10:24:34 PST
Comment on attachment 392090 [details] Patch for gtest Clearing flags on attachment: 392090 Committed r257691: <https://trac.webkit.org/changeset/257691>
WebKit Commit Bot
Comment 5 2020-03-01 10:24:36 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2020-03-01 10:25:16 PST
<rdar://problem/59930856>
Note You need to log in before you can comment on or make changes to this bug.