Bug 208358

Summary: Stop using -[CALayer setValue:forKey:] to store back pointers to PlatformCALayer*
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, dino, koivisto, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=208416
Attachments:
Description Flags
Patch
thorton: review+
Patch
none
Patch
none
Patch
none
Patch none

Simon Fraser (smfr)
Reported 2020-02-27 17:21:48 PST
Stop using -[CALayer setValue:forKey:] to store back pointers to PlatformCALayer*
Attachments
Patch (12.53 KB, patch)
2020-02-27 17:25 PST, Simon Fraser (smfr) 		thorton: review+
DetailsFormatted DiffDiff
Patch (15.14 KB, patch)
2020-02-27 22:03 PST, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (15.33 KB, patch)
2020-02-27 23:10 PST, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (15.32 KB, patch)
2020-02-27 23:38 PST, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (15.64 KB, patch)
2020-02-28 08:08 PST, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2020-02-27 17:25:43 PST
Created attachment 391945 [details] Patch
Simon Fraser (smfr)
Comment 2 2020-02-27 22:03:59 PST
Created attachment 391961 [details] Patch
Simon Fraser (smfr)
Comment 3 2020-02-27 23:10:29 PST
Created attachment 391964 [details] Patch
Simon Fraser (smfr)
Comment 4 2020-02-27 23:38:04 PST
Created attachment 391965 [details] Patch
Simon Fraser (smfr)
Comment 5 2020-02-28 08:08:17 PST
Created attachment 391981 [details] Patch
Simon Fraser (smfr)
Comment 6 2020-02-28 11:24:04 PST
https://trac.webkit.org/changeset/257645/webkit
Radar WebKit Bug Importer
Comment 7 2020-02-28 11:25:36 PST
<rdar://problem/59895819>
Aakash Jain
Comment 8 2020-02-29 09:25:05 PST
(In reply to Simon Fraser (smfr) from comment #6) > https://trac.webkit.org/changeset/257645/webkit This seems to have broken Windows build. Tracked in https://bugs.webkit.org/show_bug.cgi?id=208416 EWS also indicated this failure: https://ews-build.webkit.org/#/builders/10/builds/8585
Note You need to log in before you can comment on or make changes to this bug.