Bug 208329 – [ews] commit queue should skip building and testing for rollout patches

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Aakash Jain]

commit queue should skip building and testing for rollout patches. This would match the behavior of old ews.

[Aakash Jain]

Created attachment 391890 [details]
Patch

[Aakash Jain]

Sample run: https://ews-build.webkit-uat.org/#/builders/26/builds/926

[Jonathan Bedard]

Comment on attachment 391890 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391890&action=review

> Tools/BuildSlaveSupport/ews-build/steps.py:1584
> +    incorrectLayoutLines = None

Is this supposed to be part of this patch?

[Aakash Jain]

(In reply to Jonathan Bedard from comment #3)
> Is this supposed to be part of this patch?
Yes, without this there is an exception because self.incorrectLayoutLines in not defined in getResultSummary(). (e.g.: https://ews-build.webkit-uat.org/#/builders/26/builds/924)

  File "steps.py", line 1809, in getResultSummary
    if self.results != SUCCESS and self.incorrectLayoutLines:
  File "/usr/lib/python2.7/site-packages/buildbot/worker_transition.py", line 295, in __getattr__
    attr_name=name))
exceptions.AttributeError: 'RunWebKit1Tests' object has no attribute 'incorrectLayoutLines'

[Jonathan Bedard]

(In reply to Aakash Jain from comment #4)
> (In reply to Jonathan Bedard from comment #3)
> > Is this supposed to be part of this patch?
> Yes, without this there is an exception because self.incorrectLayoutLines in
> not defined in getResultSummary(). (e.g.:
> https://ews-build.webkit-uat.org/#/builders/26/builds/924)
> 
>   File "steps.py", line 1809, in getResultSummary
>     if self.results != SUCCESS and self.incorrectLayoutLines:
>   File "/usr/lib/python2.7/site-packages/buildbot/worker_transition.py",
> line 295, in __getattr__
>     attr_name=name))
> exceptions.AttributeError: 'RunWebKit1Tests' object has no attribute
> 'incorrectLayoutLines'

Is it supposed to be a class variable? Or should it be an instance variable?

[Aakash Jain]

Created attachment 391912 [details]
Patch

[Aakash Jain]

(In reply to Jonathan Bedard from comment #5)
> Is it supposed to be a class variable? Or should it be an instance variable?
Updated patch uses instance variable.

[Aakash Jain]

Created attachment 391975 [details]
Patch

[Aakash Jain]

Committed r257636: <https://trac.webkit.org/changeset/257636>

[Radar WebKit Bug Importer]

<rdar://problem/59886255>