| Summary: | Check for navigation to app-bound domain during script evaluation | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Kate Cheney <katherine_cheney> | ||||||||
| Component: | WebKit Misc. | Assignee: | Kate Cheney <katherine_cheney> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | aestes, bfulgham, cdumez, commit-queue, dbates, ews-watchlist, japhet, sam, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Kate Cheney
2020-02-27 08:42:37 PST
Created attachment 391894 [details]
Patch
Created attachment 391896 [details]
Patch
Comment on attachment 391896 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391896&action=review > Source/WebCore/ChangeLog:13 > + * bindings/js/ScriptController.cpp: > + (WebCore::ScriptController::executeScriptInWorld): > + * loader/FrameLoaderClient.h: > + * page/Frame.cpp: > + (WebCore::Frame::injectUserScriptImmediately): Please fill in the ChangeLog ensuring that you include why this change is being done, and what issue it is fixing. Created attachment 392233 [details]
Patch
Comment on attachment 392233 [details]
Patch
I think this looks correct based on what we discussed with Andy. Feel free to land this if the wk2 run completes successfully.
Comment on attachment 392233 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=392233&action=review > Source/WebKit/ChangeLog:56 > + (WebKit::WebPage::runJavaScript): So much state threading! :-D Thanks for the review! Looks like all EWS are green. Style bot seems to always complain when adding a new function to FrameLoaderClient.h Comment on attachment 392233 [details] Patch Clearing flags on attachment: 392233 Committed r257780: <https://trac.webkit.org/changeset/257780> All reviewed patches have been landed. Closing bug. |