Bug 208319

Summary: Check for navigation to app-bound domain during script evaluation
Product: WebKit Reporter: Kate Cheney <katherine_cheney>
Component: WebKit Misc.Assignee: Kate Cheney <katherine_cheney>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, bfulgham, cdumez, commit-queue, dbates, ews-watchlist, japhet, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Kate Cheney
Reported 2020-02-27 08:42:37 PST
We should check for navigation to app-bound domain during script evaluation
Attachments
Patch (23.18 KB, patch)
2020-02-27 12:07 PST, Kate Cheney 		no flags
DetailsFormatted DiffDiff
Patch (23.18 KB, patch)
2020-02-27 12:17 PST, Kate Cheney 		no flags
DetailsFormatted DiffDiff
Patch (67.01 KB, patch)
2020-03-02 18:05 PST, Kate Cheney 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Kate Cheney
Comment 1 2020-02-27 08:45:01 PST
<rdar://problem/57569321>
Kate Cheney
Comment 2 2020-02-27 12:07:08 PST
Created attachment 391894 [details] Patch
Kate Cheney
Comment 3 2020-02-27 12:17:51 PST
Created attachment 391896 [details] Patch
Sam Weinig
Comment 4 2020-02-28 17:16:07 PST
Comment on attachment 391896 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391896&action=review > Source/WebCore/ChangeLog:13 > + * bindings/js/ScriptController.cpp: > + (WebCore::ScriptController::executeScriptInWorld): > + * loader/FrameLoaderClient.h: > + * page/Frame.cpp: > + (WebCore::Frame::injectUserScriptImmediately): Please fill in the ChangeLog ensuring that you include why this change is being done, and what issue it is fixing.
Kate Cheney
Comment 5 2020-03-02 18:05:53 PST
Created attachment 392233 [details] Patch
Brent Fulgham
Comment 6 2020-03-02 20:37:10 PST
Comment on attachment 392233 [details] Patch I think this looks correct based on what we discussed with Andy. Feel free to land this if the wk2 run completes successfully.
Brent Fulgham
Comment 7 2020-03-02 20:38:21 PST
Comment on attachment 392233 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=392233&action=review > Source/WebKit/ChangeLog:56 > + (WebKit::WebPage::runJavaScript): So much state threading! :-D
Kate Cheney
Comment 8 2020-03-03 08:18:35 PST
Thanks for the review! Looks like all EWS are green. Style bot seems to always complain when adding a new function to FrameLoaderClient.h
WebKit Commit Bot
Comment 9 2020-03-03 09:08:17 PST
Comment on attachment 392233 [details] Patch Clearing flags on attachment: 392233 Committed r257780: <https://trac.webkit.org/changeset/257780>
WebKit Commit Bot
Comment 10 2020-03-03 09:08:19 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 11 2020-03-03 09:09:17 PST
<rdar://problem/59998428>
Note You need to log in before you can comment on or make changes to this bug.