| Summary: | [GTK] Don't use deprecated pango API | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jonathon Jongsma (jonner) <jonathon> | ||||||||
| Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | alp | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | PC | ||||||||||
| OS: | All | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Jonathon Jongsma (jonner)
2008-09-13 09:50:01 PDT
Created attachment 23397 [details]
don't use deprecated API
Notice that this requires a fairly new version of pango. I suppose we could alternately use an #ifdef around the deprecated API to check for the pango version...
Comment on attachment 23397 [details]
don't use deprecated API
Yep, 1.22 is just too recent to depend on. Change is fine if you wrap with PANGO_VERSION_CHECK() though (as we already do in another place in that file).
Created attachment 23399 [details]
Updated patch with PANGO_VERSION_CHECK guards
Wow, sorry about that. I didn't even bother to check what the current version of pango is, and 1.22 isn't even released yet. Oops. So this patch should definitely be more appropriate.
Comment on attachment 23399 [details]
Updated patch with PANGO_VERSION_CHECK guards
Our convention with version check macros is to put the success case first for consistency. Please update the patch or fix when landing, r=me otherwise
Created attachment 23415 [details]
Last patch with success case first
I also added your name as the reviewer to the changelog. I don't have commit access, so I can't land the patch.
|