Bug 208213

Summary: Stub Repository needs to call the scm constructor
Product: WebKit Reporter: Matt Lewis <jlewis3>
Component: Tools / TestsAssignee: Matt Lewis <jlewis3>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, glenn, jbedard, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch jbedard: review+

Matt Lewis
Reported 2020-02-25 12:46:30 PST
stub_repository.py needs to call the scm constructor.
Attachments
Patch (1.32 KB, patch)
2020-02-25 13:52 PST, Matt Lewis 		no flags
DetailsFormatted DiffDiff
Patch (1.75 KB, patch)
2020-02-25 14:18 PST, Matt Lewis 		jbedard: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-02-25 13:41:59 PST
<rdar://problem/59778312>
Matt Lewis
Comment 2 2020-02-25 13:52:12 PST
Created attachment 391681 [details] Patch This is actually the correct fix I think as when adding stub repository support initially we left out the scm initilization due to trying to override the fact that we don't actually have a SCM. Initiallizing it could have further complications with the filesystems that getr passed around.
Jonathan Bedard
Comment 3 2020-02-25 13:54:47 PST
Comment on attachment 391681 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391681&action=review > Tools/Scripts/webkitpy/common/checkout/scm/stub_repository.py:42 > + self.checkout_root = self.find_checkout_root(cwd) Can we call out in a comment why we aren't calling the parent's constructor? That's the sort of mistake I would expect a future contributor to make.
Matt Lewis
Comment 4 2020-02-25 14:18:16 PST
Created attachment 391686 [details] Patch Added a comment to signify why we aren't calling the parent.
Matt Lewis
Comment 5 2020-02-25 15:06:24 PST
Committed r257378: <https://trac.webkit.org/changeset/257378>
Note You need to log in before you can comment on or make changes to this bug.