Summary: | [JSC][MIPS] Adding support to Checkpoints | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Caio Lima <ticaiolima> | ||||||||
Component: | JavaScriptCore | Assignee: | Caio Lima <ticaiolima> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, ews-watchlist, jsc32, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Caio Lima
2020-02-25 07:40:46 PST
Created attachment 391653 [details]
Patch
Comment on attachment 391653 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391653&action=review r=me > Source/JavaScriptCore/offlineasm/mips.rb:688 > + if node.name =~ /^.*_return_location(?:_(?:wide16|wide32))?$/ or node.name.start_with?("_checkpoint_osr_exit_from_inlined_call_trampoline") This sounds like, we should rename _checkpoint_osr_exit_from_inlined_call_trampoline to _checkpoint_osr_exit_from_inlined_call_trampoline_return_location, because it is return-location. Can you file a FIXME here? Created attachment 391738 [details]
Patch
Created attachment 391739 [details]
Patch
(In reply to Yusuke Suzuki from comment #2) > Comment on attachment 391653 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=391653&action=review > > r=me Thank you very much for the review! > > Source/JavaScriptCore/offlineasm/mips.rb:688 > > + if node.name =~ /^.*_return_location(?:_(?:wide16|wide32))?$/ or node.name.start_with?("_checkpoint_osr_exit_from_inlined_call_trampoline") > > This sounds like, we should rename > _checkpoint_osr_exit_from_inlined_call_trampoline to > _checkpoint_osr_exit_from_inlined_call_trampoline_return_location, because > it is return-location. > Can you file a FIXME here? Done. I created https://bugs.webkit.org/show_bug.cgi?id=208236 and I'm going to upload a patch soon. Comment on attachment 391739 [details] Patch Clearing flags on attachment: 391739 Committed r257466: <https://trac.webkit.org/changeset/257466> All reviewed patches have been landed. Closing bug. |