Bug 208151

Summary: LLInt should fast path for jtrue/false on Symbols and Objects
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Keith Miller
Reported 2020-02-24 12:28:07 PST
LLInt should fast path for jtrue/false on Symbols and Objects
Attachments
Patch (4.92 KB, patch)
2020-02-24 12:32 PST, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch (4.99 KB, patch)
2020-02-24 14:23 PST, Keith Miller 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2020-02-24 12:32:55 PST
Created attachment 391566 [details] Patch
Yusuke Suzuki
Comment 2 2020-02-24 12:52:17 PST
Comment on attachment 391566 [details] Patch Does this handle masquerade-as-undefined objects? These objects need to be evaluated as false in certain context IIRC.
Keith Miller
Comment 3 2020-02-24 13:58:52 PST
(In reply to Yusuke Suzuki from comment #2) > Comment on attachment 391566 [details] > Patch > > Does this handle masquerade-as-undefined objects? These objects need to be > evaluated as false in certain context IIRC. Yeah, probably, I should have run-non-test262 tests before uploading...
Keith Miller
Comment 4 2020-02-24 14:23:45 PST
Created attachment 391576 [details] Patch
Yusuke Suzuki
Comment 5 2020-02-24 15:19:54 PST
Comment on attachment 391576 [details] Patch r=me
WebKit Commit Bot
Comment 6 2020-02-24 15:51:33 PST
Comment on attachment 391576 [details] Patch Clearing flags on attachment: 391576 Committed r257270: <https://trac.webkit.org/changeset/257270>
WebKit Commit Bot
Comment 7 2020-02-24 15:51:35 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2020-02-24 15:52:22 PST
<rdar://problem/59744579>
Note You need to log in before you can comment on or make changes to this bug.