Bug 208112

Summary: [LFC][IFC][Floats] Fix float boxes embedded to unbreakable inline runs.
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, emilio, Hironori.Fujii, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Unbreakable content with floats
none
Mix of breakable and unbreakable content
none
Floats with unbreakable content
none
Floats with breakable and unbreakable content
none
test case ^^
none
Patch
none
Floats with breakable and unbreakable content
none
Patch none

Description zalan 2020-02-23 14:03:30 PST
text_<float box></float box>_content -> potentially intrusive float embedded to [text_][_content]
Comment 1 Radar WebKit Bug Importer 2020-02-23 14:03:48 PST
<rdar://problem/59709701>
Comment 2 zalan 2020-02-23 14:16:04 PST
Created attachment 391499 [details]
Patch
Comment 3 zalan 2020-02-23 14:23:31 PST
Created attachment 391500 [details]
Unbreakable content with floats

This is a comparison of how floats embedded to unbreakable content is rendered by browsers.
Comment 4 zalan 2020-02-23 14:24:31 PST
Created attachment 391501 [details]
Mix of breakable and unbreakable content
Comment 5 zalan 2020-02-23 17:25:44 PST
Created attachment 391504 [details]
Floats with unbreakable content
Comment 6 zalan 2020-02-23 17:26:06 PST
Created attachment 391505 [details]
Floats with breakable and unbreakable content
Comment 7 zalan 2020-02-23 17:27:03 PST
Created attachment 391506 [details]
test case ^^
Comment 8 zalan 2020-02-23 17:35:28 PST
Created attachment 391507 [details]
Patch
Comment 9 zalan 2020-02-23 17:38:58 PST
Created attachment 391508 [details]
Floats with breakable and unbreakable content
Comment 10 zalan 2020-02-24 14:42:59 PST
Created attachment 391581 [details]
Patch
Comment 11 WebKit Commit Bot 2020-02-24 16:57:20 PST
The commit-queue encountered the following flaky tests while processing attachment 391581 [details]:

editing/spelling/spellcheck-paste-continuous-disabled.html bug 208016 (authors: g.czajkowski@samsung.com and mark.lam@apple.com)
The commit-queue is continuing to process your patch.
Comment 12 WebKit Commit Bot 2020-02-24 16:57:47 PST
The commit-queue encountered the following flaky tests while processing attachment 391581 [details]:

editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org)
The commit-queue is continuing to process your patch.
Comment 13 WebKit Commit Bot 2020-02-24 17:42:52 PST
Comment on attachment 391581 [details]
Patch

Clearing flags on attachment: 391581

Committed r257291: <https://trac.webkit.org/changeset/257291>
Comment 14 WebKit Commit Bot 2020-02-24 17:42:54 PST
All reviewed patches have been landed.  Closing bug.
Comment 15 Fujii Hironori 2020-02-24 23:39:35 PST
Committed r257297: <https://trac.webkit.org/changeset/257297>