Bug 208094

Summary: Enable lazy image loading by default
Product: WebKit Reporter: Maciej Stachowiak <mjs>
Component: ImagesAssignee: Nikos Mouchtaris <nmouchtaris>
Status: RESOLVED FIXED    
Severity: Enhancement CC: addyo, adieulot, bugmail, jonlee, mjs, nicolas, nmouchtaris, pp.mizdra, rik, rwlbuis, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=230998
https://bugs.webkit.org/show_bug.cgi?id=237660
Bug Depends on: 200764, 203557, 207901, 208119    
Bug Blocks: 196698    
Attachments:
Description Flags
Patch
none
enable lazy image load for webkit
none
enable lazy image load for webkit
none
Patch simon.fraser: review+

Maciej Stachowiak
Reported 2020-02-22 12:28:07 PST
This bug tracks enabling lazy image loading by default in WebKit trunk, once it seems ready.
Attachments
Patch (1.38 KB, patch)
2021-10-14 10:27 PDT, Nikos Mouchtaris 		no flags
DetailsFormatted DiffDiff
enable lazy image load for webkit (1.23 KB, patch)
2021-10-14 13:25 PDT, Nikos Mouchtaris 		no flags
DetailsFormatted DiffDiff
enable lazy image load for webkit (1.23 KB, patch)
2021-10-14 14:42 PDT, Nikos Mouchtaris 		no flags
DetailsFormatted DiffDiff
Patch (1.40 KB, patch)
2021-10-28 10:39 PDT, Nikos Mouchtaris 		simon.fraser: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Maciej Stachowiak
Comment 1 2020-02-22 12:29:21 PST
I'm not sure it's ready to be turned on yet, but this is a bug to track for when it's ready.
Radar WebKit Bug Importer
Comment 2 2020-02-22 12:30:22 PST
<rdar://problem/59700020>
Addy Osmani
Comment 3 2021-10-13 22:32:51 PDT
With the dependencies for this bug now closed (200764, 203557, 207901, 208119), is there a good chance loading=lazy might be turned on by default soon?
Nikos Mouchtaris
Comment 4 2021-10-14 10:27:52 PDT
Created attachment 441235 [details] Patch
Simon Fraser (smfr)
Comment 5 2021-10-14 12:13:18 PDT
Comment on attachment 441235 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=441235&action=review > Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml:694 > - default: false > + default: true Is this tested? > Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml:698 > - default: false > + default: true I think you want to leave this off by default. It only applies in some weird situations (maybe the fake Page associated with SVG images or something).
Nikos Mouchtaris
Comment 6 2021-10-14 13:25:40 PDT
Created attachment 441268 [details] enable lazy image load for webkit
Nikos Mouchtaris
Comment 7 2021-10-14 14:42:59 PDT
Created attachment 441289 [details] enable lazy image load for webkit
EWS
Comment 8 2021-10-14 19:22:01 PDT
Committed r284228 (243037@main): <https://commits.webkit.org/243037@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 441289 [details].
Anthony Ricaud
Comment 9 2021-10-28 03:40:43 PDT
It seems this patch enabled `IsSameSiteStrictEnforcementEnabled` instead of `LazyImageLoadingEnabled`. $ git show --pretty=oneline 30c67adc54a265473c4fd44bbab6702e9be4487a -- Source/WTF/Scripts/ at 11:39:12 30c67adc54a265473c4fd44bbab6702e9be4487a Enable lazy image loading by default https://bugs.webkit.org/show_bug.cgi?id=208094 diff --git Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml index 0266e84653..d9e36c19ed 100644 --- Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml +++ Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml @@ -700,7 +700,7 @@ IsSameSiteStrictEnforcementEnabled: WebKitLegacy: default: false WebKit: - default: false + default: true WebCore: default: false Notice @@ -700,7 +700,7 @@ IsSameSiteStrictEnforcementEnabled:
Simon Fraser (smfr)
Comment 10 2021-10-28 08:24:48 PDT
You're right. The patches look correct. I wonder if this was a merge issue by commit-queue.
Nikos Mouchtaris
Comment 11 2021-10-28 10:39:45 PDT
Created attachment 442718 [details] Patch
Alexey Proskuryakov
Comment 12 2021-10-28 11:11:59 PDT
Seems like something that needs a manual commit!
Nikos Mouchtaris
Comment 13 2021-10-28 12:56:11 PDT
Committed r284995 (243641@main): <https://commits.webkit.org/243641@main>
Note You need to log in before you can comment on or make changes to this bug.