Bug 208091 – [GTK] Page is not drawn with PSON, hardware acceleration and address typed in URL bar

• Component: WebKitGTK
• Status: RESOLVED FIXED

[Guilaume Ayoub]

Pages are not drawn when:

- hardware acceleration is enabled (it works without),
- PSON is enabled (it works in Epiphany 3.35.2 without PSON),
- an URL is given in the URL bar (it often works when the page is drawn at startup or when I click on a link).

When the cursor is moved on the page, we can see that links are where they are supposed to be on the new page: new page’s layout is done, but the old one is drawn instead.

The bug had been reported on Epiphany’s bug tracker, but they said that it’s probably a bug in WebKitGTK. It can be reproduced with Epiphany 3.35.3+ by enabling hardware acceleration and visiting a website using the URL bar.

https://gitlab.gnome.org/GNOME/epiphany/issues/1109

[Michael Catanzaro]

(In reply to Guilaume Ayoub from comment #0)
> Pages are not drawn when:
> 
> - hardware acceleration is enabled (it works without),

Specifically, when hardware acceleration policy is always, right? The bug doesn't occur for on-demand?

[Guilaume Ayoub]

> Specifically, when hardware acceleration policy is always, right? The bug
> doesn't occur for on-demand?

Exactly.

[Guilaume Ayoub]

Disabling PSON in WebKitGTK with the patch provided in https://bugs.webkit.org/show_bug.cgi?id=210287 fixes the problem.

(Using "always" for hardware acceleration gives really impressive results on my computer ♥.)

[Michael Catanzaro]

Are you building with -DWPE_RENDERER=OFF? Or do you have libwpe etc. installed?

[Michael Catanzaro]

Er I guess if my patch fixed the issue for you, then it's because you have it OFF.

AC mode is totally busted right now unless WPE_RENDERER is enabled. These bugs are the same underlying issue; we just need to remember to test both issues to ensure they're both fixed by whatever final patch we come up with.

[Guilaume Ayoub]

(In reply to Michael Catanzaro from comment #4)
> Are you building with -DWPE_RENDERER=OFF? Or do you have libwpe etc.
> installed?

I do.

> Er I guess if my patch fixed the issue for you, then it's because you have it OFF.

Of course.

> AC mode is totally busted right now unless WPE_RENDERER is enabled. These bugs are the same underlying issue; we just need to remember to test both issues to ensure they're both fixed by whatever final patch we come up with.

I won’t forget ;).

[Carlos Garcia Campos]

Created attachment 396077 [details]
Patch

[Michael Catanzaro]

Comment on attachment 396077 [details]
Patch

Nice!

[Guilaume Ayoub]

It works well for me, thank you!

[Carlos Garcia Campos]

Committed r259943: <https://trac.webkit.org/changeset/259943>