Bug 208064

Summary: [ews] Add build step to Validate ChangeLog for commit-queue
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, jbedard, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch jbedard: review+

Aakash Jain
Reported 2020-02-21 10:36:00 PST
Add build step to Validate ChangeLog. This step would be required for commit-queue, to validate whether the ChangeLog looks fine (i.e. doesn't contains OOPS, the reviewer name in 'Reviewed by XYZ' is a valid reviewer).
Attachments
Patch (3.06 KB, patch)
2020-02-21 10:40 PST, Aakash Jain 		jbedard: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2020-02-21 10:40:03 PST
Created attachment 391409 [details] Patch
Aakash Jain
Comment 2 2020-02-21 10:41:05 PST
Sample run: https://ews-build.webkit-uat.org/#/builders/26/builds/698
Jonathan Bedard
Comment 3 2020-02-21 11:59:30 PST
(In reply to Aakash Jain from comment #2) > Sample run: https://ews-build.webkit-uat.org/#/builders/26/builds/698 Do you have a successful example?
Aakash Jain
Comment 4 2020-02-21 12:14:39 PST
(In reply to Jonathan Bedard from comment #3) > Do you have a successful example? https://ews-build.webkit-uat.org/#/builders/26/builds/735
Aakash Jain
Comment 5 2020-02-21 13:12:06 PST
Committed r257157: <https://trac.webkit.org/changeset/257157>
Radar WebKit Bug Importer
Comment 6 2020-02-21 13:13:15 PST
<rdar://problem/59679885>
Aakash Jain
Comment 7 2020-03-19 15:07:18 PDT
This change seems to be working fine. e.g.: ChangeLog missing Unreviewed/Reviewed-by text: https://ews-build.webkit.org/#/builders/28/builds/64 ChangeLog containing OOPS: https://ews-build.webkit.org/#/builders/28/builds/52
Note You need to log in before you can comment on or make changes to this bug.