Bug 208053

Summary:

Update WPT tests for Intersection Observer

Product:

WebKit

Reporter:

Frédéric Wang (:fredw) <fred.wang>

Component:

WebCore Misc.

Assignee:

Frédéric Wang (:fredw) <fred.wang>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ajuma, clopez, commit-queue, jacob_uphoff, rwlbuis, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

159475, 208047

Attachments:

Description	Flags
Patch	none

Frédéric Wang (:fredw)

Reported 2020-02-21 07:03:00 PST

Let's update them...

Attachments
Patch (129.45 KB, patch) 2020-02-21 07:24 PST, Frédéric Wang (:fredw)	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Frédéric Wang (:fredw)

Comment 1 2020-02-21 07:24:38 PST

Created attachment 391396 [details] Patch

WebKit Commit Bot

Comment 2 2020-02-21 09:06:48 PST

Comment on attachment 391396 [details] Patch Clearing flags on attachment: 391396 Committed r257137: <https://trac.webkit.org/changeset/257137>

WebKit Commit Bot

Comment 3 2020-02-21 09:06:49 PST

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 4 2020-02-21 09:07:17 PST

<rdar://problem/59670001>

Jacob Uphoff

Comment 5 2020-02-26 08:44:18 PST

These two tests are missing expected files: imported/w3c/web-platform-tests/intersection-observer/v2/cross-origin-effects.sub.html imported/w3c/web-platform-tests/intersection-observer/v2/cross-origin-occlusion.sub.html

Frédéric Wang (:fredw)

Comment 6 2020-02-26 08:50:07 PST

(In reply to Jacob Uphoff from comment #5) > These two tests are missing expected files: > imported/w3c/web-platform-tests/intersection-observer/v2/cross-origin- > effects.sub.html > imported/w3c/web-platform-tests/intersection-observer/v2/cross-origin- > occlusion.sub.html OK, I think they should have been [ Skip ] rather than [ Timeout ]. I thought we were skipping timeout tests in our bot...

Jacob Uphoff

Comment 7 2020-02-26 11:55:16 PST

Skipped the test here: https://trac.webkit.org/changeset/257501/webkit

Carlos Alberto Lopez Perez

Comment 8 2020-04-20 12:45:03 PDT

(In reply to Jacob Uphoff from comment #7) > Skipped the test here: https://trac.webkit.org/changeset/257501/webkit Updated the bug url and moved the skip of this 2 tests to the general expectations in https://trac.webkit.org/changeset/260388

Note You need to log in before you can comment on or make changes to this bug.