Bug 208020

Summary:

[First paint] Let optional style recalcs go through while in visually-non-empty state.

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, cdumez, commit-queue, dbates, esprehn+autocc, ews-watchlist, kangil.han, koivisto, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Description zalan 2020-02-20 11:19:24 PST

and only throttle layouts

Comment 1 Radar WebKit Bug Importer 2020-02-20 11:19:39 PST

<rdar://problem/59636549>

Comment 2 zalan 2020-02-20 12:21:15 PST

Created attachment 391318 [details]
Patch

Comment 3 Simon Fraser (smfr) 2020-02-20 12:59:40 PST

Comment on attachment 391318 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391318&action=review

> Source/WebCore/dom/Document.cpp:1875
>      auto shouldThrottleStyleRecalc = [&] {

Doesn't seem worth keeping this lambda now.

> Source/WebCore/dom/Document.cpp:3137
> +    if (view() && view()->isVisuallyNonEmpty())
>          return false;

So this prevents the zero-delay layout timer from firing?

So need to get rid of that timer. Maybe this kills it for all post-visually-empty states?

Comment 4 zalan 2020-02-20 15:34:45 PST

Created attachment 391345 [details]
Patch

Comment 5 zalan 2020-02-20 16:57:57 PST

Created attachment 391359 [details]
Patch

Comment 6 WebKit Commit Bot 2020-02-20 19:40:42 PST

Comment on attachment 391359 [details]
Patch

Clearing flags on attachment: 391359

Committed r257126: <https://trac.webkit.org/changeset/257126>

Comment 7 WebKit Commit Bot 2020-02-20 19:40:44 PST

All reviewed patches have been landed.  Closing bug.