Bug 208020

Summary: [First paint] Let optional style recalcs go through while in visually-non-empty state.
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, cdumez, commit-queue, dbates, esprehn+autocc, ews-watchlist, kangil.han, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

alan
Reported 2020-02-20 11:19:24 PST
and only throttle layouts
Attachments
Patch (2.55 KB, patch)
2020-02-20 12:21 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (2.74 KB, patch)
2020-02-20 15:34 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (2.74 KB, patch)
2020-02-20 16:57 PST, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-02-20 11:19:39 PST
<rdar://problem/59636549>
alan
Comment 2 2020-02-20 12:21:15 PST
Created attachment 391318 [details] Patch
Simon Fraser (smfr)
Comment 3 2020-02-20 12:59:40 PST
Comment on attachment 391318 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391318&action=review > Source/WebCore/dom/Document.cpp:1875 > auto shouldThrottleStyleRecalc = [&] { Doesn't seem worth keeping this lambda now. > Source/WebCore/dom/Document.cpp:3137 > + if (view() && view()->isVisuallyNonEmpty()) > return false; So this prevents the zero-delay layout timer from firing? So need to get rid of that timer. Maybe this kills it for all post-visually-empty states?
alan
Comment 4 2020-02-20 15:34:45 PST
Created attachment 391345 [details] Patch
alan
Comment 5 2020-02-20 16:57:57 PST
Created attachment 391359 [details] Patch
WebKit Commit Bot
Comment 6 2020-02-20 19:40:42 PST
Comment on attachment 391359 [details] Patch Clearing flags on attachment: 391359 Committed r257126: <https://trac.webkit.org/changeset/257126>
WebKit Commit Bot
Comment 7 2020-02-20 19:40:44 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.