Bug 207993

Summary:

[Web Animations] Repeated animations on pseudo elements will fail to run after a while

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

Animations

Assignee:

Simon Fraser (smfr) <simon.fraser>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, cmarcelo, commit-queue, dbates, dino, esprehn+autocc, ews-watchlist, glenn, graouts, kangil.han, koivisto, kondapallykalyan, pdr, rniwa, simon.fraser, tyls.alexandr, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	zalan: review+
Patch	none
Patch	none
Patch	none
Patch	none

Simon Fraser (smfr)

Reported 2020-02-19 21:15:18 PST

[Web Animations] Repeating animations on pseudo elements will fail to run after a while

Attachments
Patch (3.37 KB, patch) 2020-02-19 21:17 PST, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Patch (11.21 KB, patch) 2020-02-20 16:38 PST, Simon Fraser (smfr)	zalan: review+	Details Formatted Diff Diff
Patch (13.77 KB, patch) 2020-02-20 21:15 PST, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Patch (13.77 KB, patch) 2020-02-20 21:18 PST, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Patch (13.97 KB, patch) 2020-02-20 21:29 PST, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Patch (13.99 KB, patch) 2020-02-21 08:09 PST, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Simon Fraser (smfr)

Comment 1 2020-02-19 21:17:57 PST

Created attachment 391255 [details] Patch

Simon Fraser (smfr)

Comment 2 2020-02-19 21:17:59 PST

<rdar://problem/59428472>

Simon Fraser (smfr)

Comment 3 2020-02-19 21:18:31 PST

Comment on attachment 391255 [details] Patch Needs a test.

Simon Fraser (smfr)

Comment 4 2020-02-19 22:28:37 PST

The assertions appear to be incorrect because there's a call to timeline->elementWasRemoved() from RenderTreeUpdater::tearDownRenderers() which is not about Element destruction. Which means I don't know when it's OK to call m_elementToCSSAnimationsCreatedByMarkupMap.remove().

Antti Koivisto

Comment 5 2020-02-20 00:03:09 PST

Yeah, that doesn't make logical sense though may work in practice. I guess the idea is to do a full cleanup. It is only called when renderTreeBeingDestroyed() and that is only set during document destruction and when entering b/f cache. The latter case is suspicious but might be fine.

Simon Fraser (smfr)

Comment 6 2020-02-20 16:38:20 PST

Created attachment 391357 [details] Patch

Dean Jackson

Comment 7 2020-02-20 19:38:04 PST

Comment on attachment 391357 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391357&action=review > Source/WebCore/animation/AnimationTimeline.cpp:227 > +void AnimationTimeline::willDestoryRendererForElement(Element& element) destroy typo

Simon Fraser (smfr)

Comment 8 2020-02-20 21:15:06 PST

Created attachment 391379 [details] Patch

Simon Fraser (smfr)

Comment 9 2020-02-20 21:18:10 PST

Created attachment 391380 [details] Patch

Simon Fraser (smfr)

Comment 10 2020-02-20 21:29:11 PST

Created attachment 391381 [details] Patch

Simon Fraser (smfr)

Comment 11 2020-02-21 08:09:26 PST

Created attachment 391398 [details] Patch