| Summary: | [WebAuthn] Replace DeviceIdentity.framework | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jiewen Tan <jiewen_tan> | ||||||
| Component: | WebKit Misc. | Assignee: | Jiewen Tan <jiewen_tan> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | benjamin, bfulgham, cdumez, cmarcelo, commit-queue, dbates, e.barg0089, ews-watchlist, jiewen_tan, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 181943 | ||||||||
| Attachments: |
|
||||||||
|
Description
Jiewen Tan
2020-02-19 19:42:05 PST
Created attachment 391254 [details]
Patch
Comment on attachment 391254 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391254&action=review > Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:312 > + WTFLogAlways("Couldn't attest: %@", error); Should actually be LOG_ERROR. Comment on attachment 391254 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391254&action=review r=me > Source/WebKit/ChangeLog:10 > + Invocations of the new framework is hidden in WKA. Please refer to the radar for detailed information. "The new experimental authentication logic is handled by WebKtAdditions. Please refer to the radar for detailed information." > Source/WebKit/ChangeLog:13 > + 1) changes the way how user consent is obtained such that biometrics will not be prompted twice. changes how user consent is obtained to avoid multiple prompts for biometric input. > Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:174 > "allow " + creationOptions.rp.id + " to create a public key credential for " + creationOptions.user.name, Should this be "makeString("allow "_s, creationOptions.rp.id, " to create a public key credential for"_s, creationOptions.user.name) Comment on attachment 391254 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391254&action=review Thanks Brent for r+ the patch. >> Source/WebKit/ChangeLog:10 >> + Invocations of the new framework is hidden in WKA. Please refer to the radar for detailed information. > > "The new experimental authentication logic is handled by WebKtAdditions. Please refer to the radar for detailed information." Fixed. >> Source/WebKit/ChangeLog:13 >> + 1) changes the way how user consent is obtained such that biometrics will not be prompted twice. > > changes how user consent is obtained to avoid multiple prompts for biometric input. Fixed. >> Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:174 >> "allow " + creationOptions.rp.id + " to create a public key credential for " + creationOptions.user.name, > > Should this be "makeString("allow "_s, creationOptions.rp.id, " to create a public key credential for"_s, creationOptions.user.name) Yes. >> Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:312 >> + WTFLogAlways("Couldn't attest: %@", error); > > Should actually be LOG_ERROR. Fixed. > Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalConnection.h:38 > +namespace WebCore { Not needed. Created attachment 391321 [details]
Patch for landing
The commit-queue encountered the following flaky tests while processing attachment 391321 [details]: editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org) The commit-queue is continuing to process your patch. Comment on attachment 391321 [details] Patch for landing Clearing flags on attachment: 391321 Committed r257085: <https://trac.webkit.org/changeset/257085> |