Bug 207980

Summary: Web Inspector: Object trees use the wrong theme of type icon
Product: WebKit Reporter: Jon Davis <jond>
Component: Web InspectorAssignee: Jon Davis <jond>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, inspector-bugzilla-changes, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Sources tab in light mode
none
Sources Tab in dark mode none

Jon Davis
Reported 2020-02-19 17:50:55 PST
Object trees currently use the dark icons for light mode and light icons for dark mode. It should be reversed.
Attachments
Patch (7.08 KB, patch)
2020-02-19 17:55 PST, Jon Davis 		no flags
DetailsFormatted DiffDiff
Sources tab in light mode (418.59 KB, image/png)
2020-02-19 17:59 PST, Jon Davis 		no flags
Details
Sources Tab in dark mode (432.50 KB, image/png)
2020-02-19 17:59 PST, Jon Davis 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Jon Davis
Comment 1 2020-02-19 17:55:40 PST
Created attachment 391231 [details] Patch
Jon Davis
Comment 2 2020-02-19 17:59:20 PST
Created attachment 391232 [details] Sources tab in light mode
Jon Davis
Comment 3 2020-02-19 17:59:35 PST
Created attachment 391233 [details] Sources Tab in dark mode
WebKit Commit Bot
Comment 4 2020-02-19 22:19:11 PST
The commit-queue encountered the following flaky tests while processing attachment 391231 [details]: editing/spelling/spellcheck-input-search-crash.html bug 207995 (authors: arv@chromium.org, g.czajkowski@samsung.com, mark.lam@apple.com, and morrita@google.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 5 2020-02-19 22:19:47 PST
Comment on attachment 391231 [details] Patch Clearing flags on attachment: 391231 Committed r257043: <https://trac.webkit.org/changeset/257043>
WebKit Commit Bot
Comment 6 2020-02-19 22:19:49 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2020-02-19 22:20:16 PST
<rdar://problem/59619181>
Note You need to log in before you can comment on or make changes to this bug.