Bug 207980 - Web Inspector: Object trees use the wrong theme of type icon
Summary: Web Inspector: Object trees use the wrong theme of type icon
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Jon Davis
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-02-19 17:50 PST by Jon Davis
Modified: 2020-02-19 22:20 PST (History)
4 users (show)

See Also:


Attachments
Patch (7.08 KB, patch)
2020-02-19 17:55 PST, Jon Davis
no flags Details | Formatted Diff | Diff
Sources tab in light mode (418.59 KB, image/png)
2020-02-19 17:59 PST, Jon Davis
no flags Details
Sources Tab in dark mode (432.50 KB, image/png)
2020-02-19 17:59 PST, Jon Davis
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jon Davis 2020-02-19 17:50:55 PST
Object trees currently use the dark icons for light mode and light icons for dark mode. It should be reversed.
Comment 1 Jon Davis 2020-02-19 17:55:40 PST
Created attachment 391231 [details]
Patch
Comment 2 Jon Davis 2020-02-19 17:59:20 PST
Created attachment 391232 [details]
Sources tab in light mode
Comment 3 Jon Davis 2020-02-19 17:59:35 PST
Created attachment 391233 [details]
Sources Tab in dark mode
Comment 4 WebKit Commit Bot 2020-02-19 22:19:11 PST
The commit-queue encountered the following flaky tests while processing attachment 391231 [details]:

editing/spelling/spellcheck-input-search-crash.html bug 207995 (authors: arv@chromium.org, g.czajkowski@samsung.com, mark.lam@apple.com, and morrita@google.com)
The commit-queue is continuing to process your patch.
Comment 5 WebKit Commit Bot 2020-02-19 22:19:47 PST
Comment on attachment 391231 [details]
Patch

Clearing flags on attachment: 391231

Committed r257043: <https://trac.webkit.org/changeset/257043>
Comment 6 WebKit Commit Bot 2020-02-19 22:19:49 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2020-02-19 22:20:16 PST
<rdar://problem/59619181>