Bug 207964

Summary: Avoid preconnecting to custom URL schemes
Product: WebKit Reporter: Ben Nham <nham>
Component: Page LoadingAssignee: Ben Nham <nham>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, cdumez, commit-queue, nham, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Ben Nham
Reported 2020-02-19 14:30:25 PST
NetworkProcess::preconnectTo preconnects to custom URL schemes, while NetworkConnectionToWebProcess::preconnectTo does not. The former's behavior should match the latter's. This will also fix the debug test failures in TestWebKitAPI.WebKit.DownloadNavigationResponseFromMemoryCache and TestWebKitAPI.ContentFiltering.LazilyLoadPlatformFrameworks introduced by https://bugs.webkit.org/show_bug.cgi?id=207777. The reason for the debug test failure is that both of these tests register a custom HTTP scheme handler, and the scheme handlers are returning responses to the preconnect request which is causing the assert in PreconnectTask::didReceiveResponse to fire.
Attachments
Patch (1.74 KB, patch)
2020-02-19 16:03 PST, Ben Nham 		no flags
DetailsFormatted DiffDiff
Patch (1.74 KB, patch)
2020-02-19 16:17 PST, Ben Nham 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-02-19 14:30:57 PST
<rdar://problem/59606178>
Ben Nham
Comment 2 2020-02-19 16:03:23 PST
Created attachment 391214 [details] Patch
Ben Nham
Comment 3 2020-02-19 16:17:13 PST
Created attachment 391217 [details] Patch
WebKit Commit Bot
Comment 4 2020-02-19 17:12:31 PST
Comment on attachment 391217 [details] Patch Clearing flags on attachment: 391217 Committed r257008: <https://trac.webkit.org/changeset/257008>
WebKit Commit Bot
Comment 5 2020-02-19 17:12:33 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.