Bug 207959 – Regression(r247567) HTTP Disk cache capacity is no longer set

• Component: WebKit2
• Status: RESOLVED FIXED

[Chris Dumez]

HTTP Disk cache capacity is no longer set since r247567 so we end up with a default capacity for std::numeric_limit<size_t>::max().

[Radar WebKit Bug Importer]

<rdar://problem/59603972>

[Chris Dumez]

Created attachment 391197 [details]
Patch

[Antti Koivisto]

Comment on attachment 391197 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391197&action=review

> Source/WebKit/NetworkProcess/cache/NetworkCache.cpp:76
> +        calculateURLCacheSizes(cacheModel, diskFreeSize, urlCacheMemoryCapacity, urlCacheDiskCapacity);
> +    }
> +    return urlCacheDiskCapacity;

This stuff could use a cleanups at some point. We have no "URL cache" and urlCacheMemoryCapacity is never used.

[Alex Christensen]

Comment on attachment 391197 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391197&action=review

> Source/WebKit/NetworkProcess/NetworkProcess.cpp:2047
> +    if (m_hasSetCacheModel && cacheModel == m_cacheModel)

m_cacheModel should be an Optional instead of a bool m_hasSetCacheModel

[Chris Dumez]

Comment on attachment 391197 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=391197&action=review

>> Source/WebKit/NetworkProcess/NetworkProcess.cpp:2047
>> +    if (m_hasSetCacheModel && cacheModel == m_cacheModel)
> 
> m_cacheModel should be an Optional instead of a bool m_hasSetCacheModel

I agree but since the patch will likely get cherry-picked, I think it is good to keep the change minimal. I will drop changes to this line. Not sure why I dropped the parentheses.

[Chris Dumez]

Created attachment 391204 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 391204 [details]
Patch

Clearing flags on attachment: 391204

Committed r256967: <https://trac.webkit.org/changeset/256967>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.