Bug 207954 – [ Mac wk2 ] http/tests/inspector/network/har/har-page.html is flaky failing

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Jason Lawrence]

http/tests/inspector/network/har/har-page.html 

Description:
This test is flaky failing throughout the visible history on Mac wk2. The diff has changed several times throughout the history, I cannot find another recent failure before this with this same diff. The most recent failure with a different diff is r256914.

History:
https://results.webkit.org/?suite=layout-tests&test=http%2Ftests%2Finspector%2Fnetwork%2Fhar%2Fhar-page.html&limit=50000&platform=mac&flavor=wk2

Diff:
--- /Volumes/Data/slave/catalina-release-tests-wk2/build/layout-test-results/http/tests/inspector/network/har/har-page-expected.txt
+++ /Volumes/Data/slave/catalina-release-tests-wk2/build/layout-test-results/http/tests/inspector/network/har/har-page-actual.txt
@@ -104,9 +104,7 @@
           "send": "<filtered>",
           "wait": "<filtered>",
           "receive": "<filtered>"
-        },
-        "_serverPort": 8000,
-        "_priority": "high"
+        }
       },
       {
         "pageref": "page_0",

[Radar WebKit Bug Importer]

<rdar://problem/59599895>

[Jason Lawrence]

I have marked this test as failing while this issue is investigated.
https://trac.webkit.org/changeset/256931/webkit

[Jason Lawrence]

I can reproduce this issue with r256933 using the command below.
run-webkit-tests http/tests/inspector/network/har/har-page.html --iterations 4000 --exit-after-n-failures 5 -f --force

[5/4000] http/tests/inspector/network/har/har-page.html failed unexpectedly (text diff)
[9/4000] http/tests/inspector/network/har/har-page.html failed unexpectedly (text diff)
[10/4000] http/tests/inspector/network/har/har-page.html failed unexpectedly (text diff)
[11/4000] http/tests/inspector/network/har/har-page.html failed unexpectedly (text diff)
[12/4000] http/tests/inspector/network/har/har-page.html failed unexpectedly (text diff)
Exiting early after 5 failures. 9 tests run.

4 tests ran as expected, 5 didn't (3991 didn't run):

[Ryan Haddad]

This test went from failing a few times a day to failing almost consistently with or around https://trac.webkit.org/changeset/259009/webkit

--- /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/http/tests/inspector/network/har/har-page-expected.txt
+++ /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/http/tests/inspector/network/har/har-page-actual.txt
@@ -87,7 +87,7 @@
           "headers": "<filtered>",
           "content": {
             "size": "<filtered>",
-            "compression": 0,
+            "compression": 7240,
             "mimeType": "application/x-javascript",
             "text": "<filtered>"
           },
@@ -104,9 +104,7 @@
           "send": "<filtered>",
           "wait": "<filtered>",
           "receive": "<filtered>"
-        },
-        "_serverPort": 8000,
-        "_priority": "high"
+        }
       },
       {
         "pageref": "page_0",
@@ -130,7 +128,7 @@
           "headers": "<filtered>",
           "content": {
             "size": "<filtered>",
-            "compression": 0,
+            "compression": 7472,
             "mimeType": "application/x-javascript",
             "text": "<filtered>"
           },
@@ -147,9 +145,7 @@
           "send": "<filtered>",
           "wait": "<filtered>",
           "receive": "<filtered>"
-        },
-        "_serverPort": 8000,
-        "_priority": "high"
+        }
       },
       {
         "pageref": "page_0",

[Devin Rousso]

Created attachment 401962 [details]
Patch

[Devin Rousso]

Created attachment 401968 [details]
Patch

lol the expected file for "har-page-aggressive-gc.html" had a title of "har-page.html" 🤣

[Maciej Stachowiak]

Comment on attachment 401968 [details]
Patch

r=me

[EWS]

Committed r263078: <https://trac.webkit.org/changeset/263078>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 401968 [details].