| Summary: | Add support for AudioSession handling in GPUProcess for capture | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||||||||
| Component: | WebRTC | Assignee: | youenn fablet <youennf> | ||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||
| Severity: | Normal | CC: | calvaris, cdumez, commit-queue, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, hta, jer.noble, philipj, sergio, tommyw, webkit-bug-importer, youennf | ||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||
| OS: | Unspecified | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
youenn fablet
2020-02-19 11:01:03 PST
Created attachment 391179 [details]
Patch
Created attachment 391205 [details]
Patch
Created attachment 391207 [details]
Patch
Comment on attachment 391207 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391207&action=review > Source/WebCore/ChangeLog:10 > + Use this new interface fo MediaStreamTrack capture sources. s/fo/to/ Comment on attachment 391207 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391207&action=review > Source/WebCore/ChangeLog:17 > + This includes BaseAudioSharedUnit, for which we add a audioUnitWillStart callback so that we compute the right AudioSession category before starting the capture. Nit: please wrap this line, it is quite long. Created attachment 391225 [details]
Patch for landing
Comment on attachment 391225 [details] Patch for landing Rejecting attachment 391225 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 391225, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in LayoutTests/ChangeLog contains OOPS!. Full output: https://webkit-queues.webkit.org/results/13325266 Created attachment 391227 [details]
Patch for landing
Comment on attachment 391227 [details] Patch for landing Rejecting attachment 391227 [details] from commit-queue. New failing tests: editing/spelling/spellcheck-async-remove-frame.html Full output: https://webkit-queues.webkit.org/results/13325288 Created attachment 391242 [details]
Archive of layout-test-results from webkit-cq-03 for mac-mojave
The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: webkit-cq-03 Port: mac-mojave Platform: Mac OS X 10.14.6
The commit-queue encountered the following flaky tests while processing attachment 391227 [details]: editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org) The commit-queue is continuing to process your patch. Comment on attachment 391227 [details] Patch for landing Clearing flags on attachment: 391227 Committed r257039: <https://trac.webkit.org/changeset/257039> All reviewed patches have been landed. Closing bug. |