Bug 207949

Summary: Disable the process cache when process-per-tab is disabled in the debug menu
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, commit-queue, ggaren, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2020-02-19 10:02:00 PST
Disable the process cache when process-per-tab is disabled in the debug menu. The process cache is a process-swap-on-navigation optimization and process-swap-on-navigation is already disabled when process-per-tab is disabled. The process cache is not useful with such configuration and actually leads to crashes too.
Attachments
Patch (2.69 KB, patch)
2020-02-19 10:03 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2020-02-19 10:02:13 PST
<rdar://problem/57094837>
Chris Dumez
Comment 2 2020-02-19 10:03:31 PST
Created attachment 391174 [details] Patch
Geoffrey Garen
Comment 3 2020-02-19 10:59:25 PST
Comment on attachment 391174 [details] Patch r=me
WebKit Commit Bot
Comment 4 2020-02-19 12:01:20 PST
The commit-queue encountered the following flaky tests while processing attachment 391174 [details]: editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 5 2020-02-19 12:01:56 PST
Comment on attachment 391174 [details] Patch Clearing flags on attachment: 391174 Committed r256932: <https://trac.webkit.org/changeset/256932>
WebKit Commit Bot
Comment 6 2020-02-19 12:01:57 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.