Bug 207949

Summary: Disable the process cache when process-per-tab is disabled in the debug menu
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, commit-queue, ggaren, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Chris Dumez 2020-02-19 10:02:00 PST
Disable the process cache when process-per-tab is disabled in the debug menu. The process cache is a process-swap-on-navigation optimization and process-swap-on-navigation is already disabled when process-per-tab is disabled. The process cache is not useful with such configuration and actually leads to crashes too.
Comment 1 Chris Dumez 2020-02-19 10:02:13 PST
<rdar://problem/57094837>
Comment 2 Chris Dumez 2020-02-19 10:03:31 PST
Created attachment 391174 [details]
Patch
Comment 3 Geoffrey Garen 2020-02-19 10:59:25 PST
Comment on attachment 391174 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2020-02-19 12:01:20 PST
The commit-queue encountered the following flaky tests while processing attachment 391174 [details]:

editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org)
The commit-queue is continuing to process your patch.
Comment 5 WebKit Commit Bot 2020-02-19 12:01:56 PST
Comment on attachment 391174 [details]
Patch

Clearing flags on attachment: 391174

Committed r256932: <https://trac.webkit.org/changeset/256932>
Comment 6 WebKit Commit Bot 2020-02-19 12:01:57 PST
All reviewed patches have been landed.  Closing bug.