Bug 207930

Summary: [Curl] Simplify Cookie class.
Product: WebKit Reporter: Takashi Komori <takashi.komori>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, basuke, chris.reid, commit-queue, don.olmstead, ews-watchlist, fujii.hironori, galpeter, gyuyoung.kim, pfeldman, ross.kirsling, ryuan.choi, sergio, stephan.szabo, takashi.komori, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Remove redundant CookieJarCurl.cpp
none
Patch
none
Patch none

Takashi Komori
Reported 2020-02-19 01:26:18 PST
In this ticket we will remove redundant implementation in curl Cookie classes.
Attachments
Remove redundant CookieJarCurl.cpp (28.96 KB, patch)
2020-02-19 01:36 PST, Takashi Komori 		no flags
DetailsFormatted DiffDiff
Patch (32.97 KB, patch)
2020-02-19 23:16 PST, Takashi Komori 		no flags
DetailsFormatted DiffDiff
Patch (32.97 KB, patch)
2020-02-19 23:47 PST, Takashi Komori 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Takashi Komori
Comment 1 2020-02-19 01:36:59 PST
Created attachment 391148 [details] Remove redundant CookieJarCurl.cpp
Basuke Suzuki
Comment 2 2020-02-19 10:23:45 PST
Comment on attachment 391148 [details] Remove redundant CookieJarCurl.cpp This is informal review: Please add a simple description of this fix. AFAIK, Curl implementation has an abstraction of cookie backend such as file-based, sqlite-based. This is a left over of those abstraction when file-based implementation was removed.
Takashi Komori
Comment 3 2020-02-19 23:16:07 PST
Created attachment 391265 [details] Patch
Takashi Komori
Comment 4 2020-02-19 23:47:14 PST
Created attachment 391266 [details] Patch
WebKit Commit Bot
Comment 5 2020-02-20 12:06:58 PST
Comment on attachment 391266 [details] Patch Clearing flags on attachment: 391266 Committed r257078: <https://trac.webkit.org/changeset/257078>
WebKit Commit Bot
Comment 6 2020-02-20 12:07:00 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2020-02-20 12:07:17 PST
<rdar://problem/59638605>
Note You need to log in before you can comment on or make changes to this bug.