Bug 207912

Summary: Expand WKRemoteObjectCoder supported POD types to encode NSURLResponse types
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: bweinstein, cdumez, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch bweinstein: review+

Alex Christensen
Reported 2020-02-18 15:00:03 PST
Expand WKRemoteObjectCoder supported POD types to encode NSURLResponse types
Attachments
Patch (12.77 KB, patch)
2020-02-18 15:03 PST, Alex Christensen 		bweinstein: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2020-02-18 15:03:03 PST
Created attachment 391097 [details] Patch
Brian Weinstein
Comment 2 2020-02-18 15:43:19 PST
Comment on attachment 391097 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391097&action=review > Source/WebKit/Shared/API/Cocoa/WKRemoteObjectCoder.mm:153 > + case 'S': { Can these two cases be the same? case ’s’: case ’S’: … > Source/WebKit/Shared/API/Cocoa/WKRemoteObjectCoder.mm:366 > + // char Nit: // unsigned char..
Alex Christensen
Comment 3 2020-02-18 15:44:37 PST
Comment on attachment 391097 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391097&action=review >> Source/WebKit/Shared/API/Cocoa/WKRemoteObjectCoder.mm:153 >> + case 'S': { > > Can these two cases be the same? > > case ’s’: > case ’S’: > … No, but one of my "short value;" should be "unsigned short value;" Will fix when landing.
Alex Christensen
Comment 4 2020-02-18 15:48:33 PST
http://trac.webkit.org/r256867
Radar WebKit Bug Importer
Comment 5 2020-02-18 15:49:20 PST
<rdar://problem/59569734>
Note You need to log in before you can comment on or make changes to this bug.