Summary: | NetworkDataTask should not expect its session wrapper to be always live | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||
Component: | Page Loading | Assignee: | youenn fablet <youennf> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | achristensen, beidson, commit-queue, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
URL: | InRadar | ||||||||
Attachments: |
|
Description
youenn fablet
2020-02-18 12:51:12 PST
Created attachment 391079 [details]
Patch
Comment on attachment 391079 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391079&action=review > Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.h:93 > + WeakPtr<SessionWrapper> m_sessionWrapper; I think the WeakPtr is necessary in case of SessionWrapper being an isolated session, which can be removed or cleared at various points in time. Comment on attachment 391079 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391079&action=review > Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:321 > if (!m_task || !m_session) Let's just replace m_session with m_sessionWrapper, which is the only one used in this function. Created attachment 391088 [details]
Patch for landing
Comment on attachment 391088 [details] Patch for landing Clearing flags on attachment: 391088 Committed r256857: <https://trac.webkit.org/changeset/256857> All reviewed patches have been landed. Closing bug. |