Bug 207895

Summary: [WK1] Flaky Test: http/tests/cookies/document-cookie-during-iframe-parsing.html
Product: WebKit Reporter: WebKit Commit Bot <commit-queue>
Component: Tools / TestsAssignee: WebKit Commit Bot <commit-queue>
Status: REOPENED ---    
Severity: Normal CC: cdumez, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 50856    
Attachments:
Description Flags
Archive of layout-test-results from webkit-cq-01 none

Description WebKit Commit Bot 2020-02-18 09:06:55 PST 
This is an automatically generated bug from the commit-queue.
http/tests/cookies/document-cookie-during-iframe-parsing.html has been flaky on the commit-queue.

http/tests/cookies/document-cookie-during-iframe-parsing.html was authored by cdumez@apple.com.
https://trac.webkit.org/browser/trunk/LayoutTests/http/tests/cookies/document-cookie-during-iframe-parsing.html

The commit-queue just saw http/tests/cookies/document-cookie-during-iframe-parsing.html flake (text diff) while processing attachment 391021 [details] on bug 207840.
Bot: webkit-cq-01  Port: <class 'webkitpy.common.config.ports.MacPort'>  Platform: Mac OS X 10.14.6

The bots will update this with information from each new failure.

If you believe this bug to be fixed or invalid, feel free to close.  The bots will re-open if the flake re-occurs.

If you would like to track this test fix with another bug, please close this bug as a duplicate.  The bots will follow the duplicate chain when making future comments.
Comment 1 WebKit Commit Bot 2020-02-18 09:06:56 PST 
Created attachment 391053 [details]
Archive of layout-test-results from webkit-cq-01
Comment 2 Chris Dumez 2020-02-18 09:19:27 PST 
--- /Volumes/Data/EWS/WebKit/WebKitBuild/Release/layout-test-results/http/tests/cookies/document-cookie-during-iframe-parsing-expected.txt
+++ /Volumes/Data/EWS/WebKit/WebKitBuild/Release/layout-test-results/http/tests/cookies/document-cookie-during-iframe-parsing-actual.txt
@@ -5,7 +5,7 @@
 
 PASS normalizeCookie(document.cookie) is "testKey=testValue"
 PASS normalizeCookie(cookiesInFrame) is "foo=bar; testKey=testValue"
-PASS normalizeCookie(document.cookie) is "foo=bar; testKey=testValue"
+FAIL normalizeCookie(document.cookie) should be foo=bar; testKey=testValue. Was testKey=testValue.
 PASS successfullyParsed is true
 
 TEST COMPLETE

And the commit queue is not using the new cookie cache yet AFAIK.
Comment 3 Chris Dumez 2020-02-18 11:24:49 PST 
Committed r256842: <https://trac.webkit.org/changeset/256842>
Comment 4 Chris Dumez 2020-02-18 11:25:15 PST 
Reopening as I merely updated test expectations.
Comment 5 Radar WebKit Bug Importer 2020-02-18 11:25:20 PST 
<rdar://problem/59558164>
Comment 6 Chris Dumez 2020-02-18 12:01:30 PST 
Committed r256847: <https://trac.webkit.org/changeset/256847>
Comment 7 Chris Dumez 2020-02-18 12:01:52 PST 
Reopening as I only updated expectations.
Comment 8 Alexey Proskuryakov 2020-02-18 15:09:17 PST 
This is a new test added in http://trac.webkit.org/r256820
Comment 9 Chris Dumez 2020-02-18 15:10:50 PST 
(In reply to Alexey Proskuryakov from comment #8)
> This is a new test added in http://trac.webkit.org/r256820

Correct, seems to have uncovered a race in CFNetwork :/