Bug 20788

Summary: Split CharacterClassConstructor into its own file
Product: WebKit Reporter: Cameron Zwarich (cpst) <zwarich>
Component: JavaScriptCoreAssignee: Cameron Zwarich (cpst) <zwarich>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed patch
none
Revised proposed patch mjs: review+

Description Cameron Zwarich (cpst) 2008-09-11 13:29:09 PDT
We should really split WREC into multiple pieces. I have a patch that does this for CharacterClassConstructor.
Comment 1 Cameron Zwarich (cpst) 2008-09-11 13:32:38 PDT
Created attachment 23357 [details]
Proposed patch

Sorry that the renames don't come out in the diff, but they can all be seen in CharacterClassConstructor.h
Comment 2 Cameron Zwarich (cpst) 2008-09-11 13:39:18 PDT
Created attachment 23358 [details]
Revised proposed patch

I forgot to make CharacterClassConstructor a class rather than a struct, and I had an unused accessor function.
Comment 3 Maciej Stachowiak 2008-09-11 14:07:07 PDT
Comment on attachment 23358 [details]
Revised proposed patch

r=me
Comment 4 Maciej Stachowiak 2008-09-11 14:07:07 PDT
Comment on attachment 23358 [details]
Revised proposed patch

r=me
Comment 5 Cameron Zwarich (cpst) 2008-09-11 15:47:47 PDT
Landed in r36337 and r36338.