Bug 207870

Summary: Move from "layer flush" terminology to "rendering update"
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, benjamin, cdumez, cmarcelo, commit-queue, dbates, esprehn+autocc, ews-watchlist, gyuyoung.kim, japhet, kangil.han, koivisto, luiz, noam, ryuan.choi, sabouhallawa, sergio, simon.fraser, thorton, webkit-bug-importer, zeno
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
thorton: review+
Patch
none
Patch
none
Patch none

Simon Fraser (smfr)
Reported 2020-02-17 16:44:19 PST
Move from "layer flush" terminology to "rendering update"
Attachments
Patch (73.33 KB, patch)
2020-02-17 16:46 PST, Simon Fraser (smfr) 		thorton: review+
DetailsFormatted DiffDiff
Patch (75.76 KB, patch)
2020-02-17 17:32 PST, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (79.06 KB, patch)
2020-02-17 18:59 PST, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (80.30 KB, patch)
2020-02-17 23:01 PST, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2020-02-17 16:46:36 PST
Created attachment 391002 [details] Patch
Tim Horton
Comment 2 2020-02-17 16:51:06 PST
Comment on attachment 391002 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391002&action=review > Source/WebCore/page/ChromeClient.h:342 > + virtual bool adjustRenderUpdateThrottling(OptionSet<RenderingUpdateThrottleState>) { return false; } should this be an -ing? > Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.h:159 > + bool m_nextRenderingUpdateIsImmediate { false }; If we're changing the name, can we change it to something less mysterious?
Simon Fraser (smfr)
Comment 3 2020-02-17 17:32:12 PST
Created attachment 391010 [details] Patch
Simon Fraser (smfr)
Comment 4 2020-02-17 18:59:55 PST
Created attachment 391020 [details] Patch
Simon Fraser (smfr)
Comment 5 2020-02-17 23:01:45 PST
Created attachment 391032 [details] Patch
Antti Koivisto
Comment 6 2020-02-18 02:16:39 PST
Comment on attachment 391032 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391032&action=review > Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp:211 > + } > } Weird indentation.
Antti Koivisto
Comment 7 2020-02-18 06:18:23 PST
Is there some terminology confusion here with the HTML concept of "rendering update"? To reach visually non-empty state we need to update layout without doing any layer flushes. Should there be a concept of "visual rendering update" or similar?
Simon Fraser (smfr)
Comment 8 2020-02-18 08:10:11 PST
(In reply to Antti Koivisto from comment #7) > Is there some terminology confusion here with the HTML concept of "rendering > update"? Perhaps, but I was trying to match this terminology on purpose. > To reach visually non-empty state we need to update layout without > doing any layer flushes. Should there be a concept of "visual rendering > update" or similar? Probably!
WebKit Commit Bot
Comment 9 2020-02-18 09:24:35 PST
Comment on attachment 391032 [details] Patch Clearing flags on attachment: 391032 Committed r256834: <https://trac.webkit.org/changeset/256834>
Radar WebKit Bug Importer
Comment 10 2020-02-26 14:46:15 PST
<rdar://problem/59822371>
Note You need to log in before you can comment on or make changes to this bug.