Bug 207834

Summary:

Fix check-webkit-style errors related to AVFoundationSPI.h

Product:

WebKit

Reporter:

Peng Liu <peng.liu6>

Component:

Media

Assignee:

Peng Liu <peng.liu6>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, benjamin, cdumez, cmarcelo, commit-queue, darin, dbates, eric.carlson, ews-watchlist, glenn, jbedard, jer.noble, philipj, sergio, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
WIP patch	none
Soft-link headers can be included either in "file.h" or <file.h>	none
Patch	none
Updated follow-up patch to revert the change regarding header order	none

Description Peng Liu 2020-02-16 22:43:51 PST

Fix check-webkit-style errors related to AVFoundationSPI.h

Comment 1 Peng Liu 2020-02-17 00:06:30 PST

Created attachment 390904 [details]
WIP patch

Comment 2 Peng Liu 2020-02-17 10:25:35 PST

Created attachment 390932 [details]
Soft-link headers can be included either in "file.h" or <file.h>

Comment 3 Radar WebKit Bug Importer 2020-02-17 13:19:19 PST

<rdar://problem/59523191>

Comment 4 WebKit Commit Bot 2020-02-17 13:55:56 PST

Comment on attachment 390932 [details]
Soft-link headers can be included either in "file.h" or <file.h>

Clearing flags on attachment: 390932

Committed r256770: <https://trac.webkit.org/changeset/256770>

Comment 5 WebKit Commit Bot 2020-02-17 13:55:58 PST

All reviewed patches have been landed.  Closing bug.

Comment 6 Darin Adler 2020-02-18 20:13:03 PST

Comment on attachment 390932 [details]
Soft-link headers can be included either in "file.h" or <file.h>

View in context: https://bugs.webkit.org/attachment.cgi?id=390932&action=review

> Tools/ChangeLog:8
> +        We need to use case-insensitive comparison to check whether the headers are alphabetically sorted in each header section.

What? No! Who decided this? I do not agree that this should change.

We aren’t switching to case-insensitive comparison. There are thousands or source files and they are sorted case sensitively. This needs to be rolled back.

Comment 7 Peng Liu 2020-02-18 20:49:03 PST

Comment on attachment 390932 [details]
Soft-link headers can be included either in "file.h" or <file.h>

View in context: https://bugs.webkit.org/attachment.cgi?id=390932&action=review

>> Tools/ChangeLog:8
>> +        We need to use case-insensitive comparison to check whether the headers are alphabetically sorted in each header section.
> 
> What? No! Who decided this? I do not agree that this should change.
> 
> We aren’t switching to case-insensitive comparison. There are thousands or source files and they are sorted case sensitively. This needs to be rolled back.

Oh, sorry, you are right. I just reviewed the code style guidelines. That was done by mistake. Will reopen this bug and rollout this change.

Comment 8 Peng Liu 2020-02-18 20:50:44 PST

Reopen this bug to rollout the change regarding the headers ordering.

Comment 9 Peng Liu 2020-02-18 21:00:54 PST

Created attachment 391140 [details]
Patch

Comment 10 Peng Liu 2020-02-19 12:28:04 PST

Created attachment 391190 [details]
Updated follow-up patch to revert the change regarding header order

Comment 11 Daniel Bates 2020-02-19 14:33:29 PST

Comment on attachment 391190 [details]
Updated follow-up patch to revert the change regarding header order

r=me

Comment 12 WebKit Commit Bot 2020-02-19 16:57:31 PST

Comment on attachment 391190 [details]
Updated follow-up patch to revert the change regarding header order

Clearing flags on attachment: 391190

Committed r257003: <https://trac.webkit.org/changeset/257003>

Comment 13 WebKit Commit Bot 2020-02-19 16:57:33 PST

All reviewed patches have been landed.  Closing bug.