Bug 207795

Summary: Stop using QTKit for rendering WK1 video fullscreen controls
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, calvaris, cdumez, commit-queue, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jonlee, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=208156
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
jonlee: review+
Patch for landing none

Jer Noble
Reported 2020-02-14 14:54:58 PST
Stop using QTKit for rendering WK1 video fullscreen controls
Attachments
Patch (75.75 KB, patch)
2020-02-14 15:05 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (77.76 KB, patch)
2020-02-17 10:13 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (77.83 KB, patch)
2020-02-17 11:02 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (82.07 KB, patch)
2020-02-17 11:58 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (84.06 KB, patch)
2020-02-17 13:42 PST, Jer Noble 		jonlee: review+
DetailsFormatted DiffDiff
Patch for landing (85.50 KB, patch)
2020-02-22 14:34 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2020-02-14 14:55:45 PST
<rdar://problem/48894915>
Jer Noble
Comment 2 2020-02-14 15:05:03 PST
Created attachment 390828 [details] Patch
Xabier Rodríguez Calvar
Comment 3 2020-02-17 02:05:18 PST
Comment on attachment 390828 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390828&action=review > Source/WebKitLegacy/mac/ChangeLog:12 > + move the fullscreen winodw to a separate space. This requires subclassing AVPlayerView so that window
Jer Noble
Comment 4 2020-02-17 10:13:31 PST
Created attachment 390931 [details] Patch
Aakash Jain
Comment 5 2020-02-17 10:29:17 PST
Comment on attachment 390931 [details] Patch Seems to break the build: iOS: PAL/pal/spi/cocoa/AVKitSPI.h:33:33: error: cannot find interface declaration for 'UIResponder', superclass of 'AVPlayerController' https://ews-build.webkit.org/#/builders/23/builds/10800/steps/7/logs/errors macOS: clang: error: no such file or directory: '/Volumes/Data/worker/macOS-Mojave-Release-Build-EWS/build/Source/WebKitLegacy/mac/WebView/WebVideoFullscreenHUDWindowController.mm' https://ews-build.webkit.org/#/builders/33/builds/3067/steps/7/logs/errors
Jer Noble
Comment 6 2020-02-17 11:02:37 PST
Created attachment 390942 [details] Patch
Jer Noble
Comment 7 2020-02-17 11:58:29 PST
Created attachment 390957 [details] Patch
Jer Noble
Comment 8 2020-02-17 13:42:21 PST
Created attachment 390970 [details] Patch
Jon Lee
Comment 9 2020-02-19 16:40:34 PST
Comment on attachment 390970 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390970&action=review > Source/WebKitLegacy/mac/WebView/WebVideoFullscreenController.mm:193 > +// [[NSNotificationCenter defaultCenter] addObserver:self selector:@selector(applicationDidChangeScreenParameters:) name:NSApplicationDidChangeScreenParametersNotification object:NSApp]; please remove.
Jer Noble
Comment 10 2020-02-22 14:34:50 PST
Created attachment 391468 [details] Patch for landing
WebKit Commit Bot
Comment 11 2020-02-22 21:46:02 PST
Comment on attachment 391468 [details] Patch for landing Clearing flags on attachment: 391468 Committed r257189: <https://trac.webkit.org/changeset/257189>
Note You need to log in before you can comment on or make changes to this bug.