Summary: | [WPE] WPEQtView.h includes the uninstalled WPEQtViewBackend.h | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alberto Garcia <berto> | ||||
Component: | WPE WebKit | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bugs-noreply, pnormand | ||||
Priority: | P2 | ||||||
Version: | Other | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Alberto Garcia
2020-02-14 07:37:07 PST
Seeing m_backend is private in WPEQtView, perhaps a forward-declaration would be enough? I would expect that a forward declaration is enough, but I don't know if WPEQtViewBackend is supposed to be public at all. The ViewBackend is meant to remain internal and shouldn't be exposed to app, IMHO :) Created attachment 390770 [details]
Patch
Comment on attachment 390770 [details]
Patch
Thanks, looks good. I'm just doing a local build to test, because the EWS doesn't support it.
Committed r256612: <https://trac.webkit.org/changeset/256612> |