|Summary:||[WPE] WPEQtView.h includes the uninstalled WPEQtViewBackend.h|
|Product:||WebKit||Reporter:||Alberto Garcia <berto>|
|Component:||WPE WebKit||Assignee:||Nobody <webkit-unassigned>|
Description Alberto Garcia 2020-02-14 07:37:07 PST
Comment 1 Philippe Normand 2020-02-14 07:49:11 PST
Seeing m_backend is private in WPEQtView, perhaps a forward-declaration would be enough?
Comment 2 Alberto Garcia 2020-02-14 07:53:15 PST
I would expect that a forward declaration is enough, but I don't know if WPEQtViewBackend is supposed to be public at all.
Comment 3 Philippe Normand 2020-02-14 07:54:30 PST
The ViewBackend is meant to remain internal and shouldn't be exposed to app, IMHO :)
Comment 4 Alberto Garcia 2020-02-14 08:00:54 PST
Created attachment 390770 [details] Patch
Comment 5 Philippe Normand 2020-02-14 08:28:51 PST
Comment on attachment 390770 [details] Patch Thanks, looks good. I'm just doing a local build to test, because the EWS doesn't support it.
Comment 6 Alberto Garcia 2020-02-14 08:43:38 PST
Committed r256612: <https://trac.webkit.org/changeset/256612>