Bug 207765

Summary: [WPE] WPEQtView.h includes the uninstalled WPEQtViewBackend.h
Product: WebKit Reporter: Alberto Garcia <berto>
Component: WPE WebKitAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, pnormand
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch pnormand: review+

Alberto Garcia
Reported 2020-02-14 07:37:07 PST
When the Qt API is enabled then WPEQtView.h and WPEQtViewLoadRequest.h are installed (see Source/WebKit/PlatformWPE.cmake) However the former also includes WPEQtViewBackend.h, which is not installed. So we should either install that header, or forward-declare WPEQtViewBackend in WPEQtView.h
Attachments
Patch (1.65 KB, patch)
2020-02-14 08:00 PST, Alberto Garcia 		pnormand: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2020-02-14 07:49:11 PST
Seeing m_backend is private in WPEQtView, perhaps a forward-declaration would be enough?
Alberto Garcia
Comment 2 2020-02-14 07:53:15 PST
I would expect that a forward declaration is enough, but I don't know if WPEQtViewBackend is supposed to be public at all.
Philippe Normand
Comment 3 2020-02-14 07:54:30 PST
The ViewBackend is meant to remain internal and shouldn't be exposed to app, IMHO :)
Alberto Garcia
Comment 4 2020-02-14 08:00:54 PST
Created attachment 390770 [details] Patch
Philippe Normand
Comment 5 2020-02-14 08:28:51 PST
Comment on attachment 390770 [details] Patch Thanks, looks good. I'm just doing a local build to test, because the EWS doesn't support it.
Alberto Garcia
Comment 6 2020-02-14 08:43:38 PST
Committed r256612: <https://trac.webkit.org/changeset/256612>
Note You need to log in before you can comment on or make changes to this bug.