Bug 207733

Summary: MediaToolbox may not be available; check before calling MTOverrideShouldPlayHDRVideo()
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, mjs, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Jer Noble 2020-02-13 17:21:58 PST 
MediaToolbox may not be available; check before calling MTOverrideShouldPlayHDRVideo()
Comment 1 Jer Noble 2020-02-13 17:22:15 PST 
<rdar://problem/59441647>
Comment 2 Jer Noble 2020-02-13 17:22:59 PST 
Created attachment 390709 [details]
Patch
Comment 3 Maciej Stachowiak 2020-02-13 19:02:30 PST 
Comment on attachment 390709 [details]
Patch

r=me

Is there way to make a test for this?
Comment 4 Jer Noble 2020-02-13 19:25:14 PST 
Not really. You’d have to literally delete MediaToolbox from the file system in order to induce this condition.
Comment 5 WebKit Commit Bot 2020-02-13 19:48:39 PST 
Comment on attachment 390709 [details]
Patch

Clearing flags on attachment: 390709

Committed r256584: <https://trac.webkit.org/changeset/256584>
Comment 6 WebKit Commit Bot 2020-02-13 19:48:40 PST 
All reviewed patches have been landed.  Closing bug.