Bug 207729

Summary: [PlayStation] Make special udis86 C file handling only happen for Visual Studio
Product: WebKit Reporter: Stephan Szabo <stephan.szabo>
Component: CMakeAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, commit-queue, don.olmstead, ews-watchlist, gyuyoung.kim, keith_miller, mark.lam, msaboff, ryuan.choi, saam, sergio, tzagallo, yoshiaki.jitsukawa
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Stephan Szabo
Reported 2020-02-13 16:37:50 PST
For Visual Studio, we have a problem where the c++ standard flag gets set to C files (but Ninja does not add the flag). We now set the source file properties to set the language to CXX which makes Visual Studio building work, however breaks some ninja builds with the same error (now Ninja thinks it's C++ code so adds the flag, but then the compiler tries to compile it as C and fails).
Attachments
Patch (1.95 KB, patch)
2020-02-13 16:41 PST, Stephan Szabo 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Stephan Szabo
Comment 1 2020-02-13 16:41:16 PST
Created attachment 390703 [details] Patch
WebKit Commit Bot
Comment 2 2020-02-13 18:24:32 PST
The commit-queue encountered the following flaky tests while processing attachment 390703 [details]: editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 3 2020-02-13 18:25:10 PST
Comment on attachment 390703 [details] Patch Clearing flags on attachment: 390703 Committed r256579: <https://trac.webkit.org/changeset/256579>
WebKit Commit Bot
Comment 4 2020-02-13 18:25:12 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.