Summary: | [LFC][IFC] Remove LineLayoutContext::m_partialTrailingTextItem | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | zalan <zalan> | ||||||
Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bfulgham, commit-queue, koivisto, simon.fraser, webkit-bug-importer, zalan | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
zalan
2020-02-12 16:17:22 PST
Created attachment 390584 [details]
Patch
Comment on attachment 390584 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390584&action=review > Source/WebCore/layout/inlineformatting/LineLayoutContext.h:-85 > Optional<InlineTextItem> m_partialLeadingTextItem; > - Optional<InlineTextItem> m_partialTrailingTextItem; Why not both? (In reply to Antti Koivisto from comment #3) > Comment on attachment 390584 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=390584&action=review > > > Source/WebCore/layout/inlineformatting/LineLayoutContext.h:-85 > > Optional<InlineTextItem> m_partialLeadingTextItem; > > - Optional<InlineTextItem> m_partialTrailingTextItem; > > Why not both? The partial leading needs a bit more work. LineBreaker can actually hold onto it as the last wrapping opportunity (this is the rare revert case). I am addressing it in a separate patch. Created attachment 390591 [details]
Patch
Comment on attachment 390591 [details] Patch Clearing flags on attachment: 390591 Committed r256499: <https://trac.webkit.org/changeset/256499> All reviewed patches have been landed. Closing bug. |