Bug 207656

Summary: [Curl] Force HTTP/1.1 for WebSocket connection
Product: WebKit Reporter: Basuke Suzuki <basuke>
Component: PlatformAssignee: Basuke Suzuki <basuke>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, basuke, commit-queue, don.olmstead, ews-watchlist, galpeter, Hironori.Fujii, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=207658
https://bugs.webkit.org/show_bug.cgi?id=176483
Attachments:
Description Flags
PATCH none

Basuke Suzuki
Reported 2020-02-12 12:39:18 PST
Curl layer currently doesn't support WebSocket over HTTP/2. Just disable HTTP/2 for now.
Attachments
PATCH (1.33 KB, patch)
2020-02-12 12:47 PST, Basuke Suzuki 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Basuke Suzuki
Comment 1 2020-02-12 12:39:42 PST
For future reference, https://tools.ietf.org/html/rfc8441
Basuke Suzuki
Comment 2 2020-02-12 12:40:59 PST
Here's Mozilla implementation record: https://bugzilla.mozilla.org/show_bug.cgi?id=1434137
Basuke Suzuki
Comment 3 2020-02-12 12:47:55 PST
Created attachment 390548 [details] PATCH
WebKit Commit Bot
Comment 4 2020-02-12 15:09:40 PST
The commit-queue encountered the following flaky tests while processing attachment 390548 [details]: editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 5 2020-02-12 15:10:02 PST
The commit-queue encountered the following flaky tests while processing attachment 390548 [details]: editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 6 2020-02-12 15:47:02 PST
Comment on attachment 390548 [details] PATCH Clearing flags on attachment: 390548 Committed r256487: <https://trac.webkit.org/changeset/256487>
WebKit Commit Bot
Comment 7 2020-02-12 15:47:04 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2020-02-12 15:48:14 PST
<rdar://problem/59404767>
Fujii Hironori
Comment 9 2020-02-13 18:54:20 PST
I confirmed the latest WinCairo works fine. It was so annoying. Thanks you very much! https://ews-build.webkit.org/ https://libwebsockets.org/testserver/
Note You need to log in before you can comment on or make changes to this bug.