Bug 207615 – macCatalyst: Unable to grab scrollbar on editable text field

• Component: WebKit2
• Status: RESOLVED FIXED

[Wenson Hsieh]

<rdar://problem/59212993>

[Wenson Hsieh]

Created attachment 390493 [details]
Patch

[Tim Horton]

Comment on attachment 390493 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390493&action=review

> Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.mm:184
> +        if ([NSStringFromClass(view.class) isEqualToString:@"_UIScrollViewScrollIndicator"] && [view.superview isKindOfClass:WKChildScrollView.class]) {

NSStringFromClass every time is probably not a great plan. Maybe look up the class from string once, keep it, and use isKindOfClass?

Or at least flip the conditions?

[Wenson Hsieh]

Comment on attachment 390493 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390493&action=review

>> Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.mm:184
>> +        if ([NSStringFromClass(view.class) isEqualToString:@"_UIScrollViewScrollIndicator"] && [view.superview isKindOfClass:WKChildScrollView.class]) {
> 
> NSStringFromClass every time is probably not a great plan. Maybe look up the class from string once, keep it, and use isKindOfClass?
> 
> Or at least flip the conditions?

Good catch! I'll cache the class in a static helper (using dispatch_once) and pass it into -isKindOfClass.

[Wenson Hsieh]

Created attachment 390494 [details]
Patch

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 390494 [details]:

editing/spelling/spellcheck-attribute.html bug 206178 (authors: [e-mail], [e-mail], and [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 390494 [details]
Patch

Clearing flags on attachment: 390494

Committed r256433: <https://trac.webkit.org/changeset/256433>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.