Bug 207612

Summary: [LFC][IFC] Do not create Display::Boxes for anonymous inline text boxes
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

alan
Reported 2020-02-11 20:24:30 PST
<div>foobar</div> [foobar] needs only a Display::Run but no Display::Box.
Attachments
Patch (4.36 KB, patch)
2020-02-11 20:27 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (4.46 KB, patch)
2020-02-12 11:18 PST, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-02-11 20:24:46 PST
<rdar://problem/59374909>
alan
Comment 2 2020-02-11 20:27:18 PST
Created attachment 390488 [details] Patch
Antti Koivisto
Comment 3 2020-02-12 08:30:25 PST
Comment on attachment 390488 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390488&action=review > Source/WebCore/layout/inlineformatting/InlineFormattingContext.cpp:491 > if (lineRun.isLineBreak()) { > + auto& displayBox = formattingState.displayBox(layoutBox); Could we avoid this too?
alan
Comment 4 2020-02-12 11:18:13 PST
Created attachment 390540 [details] Patch
WebKit Commit Bot
Comment 5 2020-02-12 12:01:19 PST
Comment on attachment 390540 [details] Patch Clearing flags on attachment: 390540 Committed r256466: <https://trac.webkit.org/changeset/256466>
WebKit Commit Bot
Comment 6 2020-02-12 12:01:21 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.