Bug 207601

Summary: Fix highlight text decorations to work with all decoration types and colors
Product: WebKit Reporter: Megan Gardner <megan_gardner>
Component: New BugsAssignee: Megan Gardner <megan_gardner>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, mmaxfield, pdr, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Description Megan Gardner 2020-02-11 16:46:55 PST
Fix highlight text decorations to work with all decoration types and colors
Comment 1 Megan Gardner 2020-02-11 16:56:42 PST
Created attachment 390469 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2020-02-11 19:42:18 PST
<rdar://problem/59374153>
Comment 3 Dean Jackson 2020-02-12 09:38:40 PST
Comment on attachment 390469 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390469&action=review

> Source/WebCore/ChangeLog:11
> +        Extended http/wpt/css/css-highlight-api/highlight-text-decorations.html.

What are our plans to contribute this back to WPT?

> Source/WebCore/rendering/TextDecorationPainter.cpp:377
> +    Color result = style.visitedDependentColorWithColorFilter(CSSPropertyTextDecorationColor);

auto?
Comment 4 Simon Fraser (smfr) 2020-02-12 09:40:06 PST
Comment on attachment 390469 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390469&action=review

> LayoutTests/http/wpt/css/css-highlight-api/highlight-text-decorations-expected.html:10
> +        text-decoration: underline;
> +        text-decoration-color: red;

Bad indentation or tabs.
Comment 5 Megan Gardner 2020-02-12 09:46:59 PST
Dean, we plan on pushing them back at some point in time, but probably not until we fix the issues that require the obscurers.
Comment 6 Megan Gardner 2020-02-12 09:48:54 PST
Created attachment 390530 [details]
Patch for landing
Comment 7 WebKit Commit Bot 2020-02-12 10:40:28 PST
Comment on attachment 390530 [details]
Patch for landing

Clearing flags on attachment: 390530

Committed r256451: <https://trac.webkit.org/changeset/256451>
Comment 8 WebKit Commit Bot 2020-02-12 10:40:30 PST
All reviewed patches have been landed.  Closing bug.