Summary: | Allow use of proxies in MiniBrowser | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ben Nham <nham> | ||||||
Component: | Page Loading | Assignee: | Ben Nham <nham> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | achristensen, beidson, commit-queue, koivisto, nham, sam, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Ben Nham
2020-02-11 16:14:37 PST
Created attachment 390458 [details]
Patch
Created attachment 390486 [details]
Patch
Comment on attachment 390486 [details] Patch Clearing flags on attachment: 390486 Committed r256530: <https://trac.webkit.org/changeset/256530> All reviewed patches have been landed. Closing bug. Comment on attachment 390486 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390486&action=review > Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:386 > parameters.defaultDataStoreParameters.networkSessionParameters.httpProxy = URL(URL(), [defaults stringForKey:(NSString *)WebKit2HTTPProxyDefaultsKey]); This patch is good, but we should be pushing Safari and MiniBrowser towards using SPI when they want proxies rather than checking in defaults ourselves. Why are we special casing these apps? Seems like what a preference they enable or entitlements are for if we want to limit this for some reason. |