Bug 207597

Summary: ANGLE has unused bison and glmark2 code
Product: WebKit Reporter: Dean Jackson <dino>
Component: New BugsAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, graouts, kondapallykalyan, mjs, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch mjs: review+

Description Dean Jackson 2020-02-11 16:13:14 PST
ANGLE fails fatal gpl2_source_code and gpl3_source_code verifiers during build
Comment 1 Dean Jackson 2020-02-11 16:13:43 PST
rdar://59361460
Comment 2 Dean Jackson 2020-02-11 16:16:04 PST
Created attachment 390457 [details]
Patch
Comment 3 EWS Watchlist 2020-02-11 16:17:25 PST
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
Comment 4 Dean Jackson 2020-02-11 16:26:47 PST
Created attachment 390460 [details]
Patch
Comment 5 Maciej Stachowiak 2020-02-11 16:27:48 PST
Comment on attachment 390460 [details]
Patch

glmarkā€™s README.angle says GPLv3, bnut the individual files removed in this patch have a BSD license header. What's up with that? Is it just the README that's wrong?

r=me
Comment 6 Dean Jackson 2020-02-12 09:34:11 PST
Committed r256443: <https://trac.webkit.org/changeset/256443>