Bug 207530

Summary: [LFC] Introduce Layout::InlineTextBox
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, bfulgham, commit-queue, ews-watchlist, gyuyoung.kim, koivisto, ryuan.choi, sergio, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

zalan
Reported 2020-02-10 19:49:16 PST
Layout::Box with Optional<text content> looks a bit odd.
Attachments
Patch (53.80 KB, patch)
2020-02-10 20:04 PST, zalan 		no flags
DetailsFormatted DiffDiff
Patch (51.49 KB, patch)
2020-02-10 20:53 PST, zalan 		no flags
DetailsFormatted DiffDiff
Patch (51.96 KB, patch)
2020-02-10 20:57 PST, zalan 		no flags
DetailsFormatted DiffDiff
Patch (52.10 KB, patch)
2020-02-10 21:28 PST, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-02-10 19:49:35 PST
<rdar://problem/59336020>
zalan
Comment 2 2020-02-10 20:04:49 PST
Created attachment 390340 [details] Patch
Antti Koivisto
Comment 3 2020-02-10 20:19:56 PST
Comment on attachment 390340 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=390340&action=review > Source/WebCore/layout/layouttree/AnonymousInlineTextBox.h:37 > +class AnonymousInlineTextBox : public Box { Shorter name would be cool as discussed. > Source/WebCore/layout/layouttree/TextContext.h:-35 > -struct TextContext { Another Context bites the dust!
zalan
Comment 4 2020-02-10 20:53:46 PST
Created attachment 390342 [details] Patch
zalan
Comment 5 2020-02-10 20:57:15 PST
Created attachment 390343 [details] Patch
zalan
Comment 6 2020-02-10 21:28:49 PST
Created attachment 390344 [details] Patch
WebKit Commit Bot
Comment 7 2020-02-11 06:53:23 PST
The commit-queue encountered the following flaky tests while processing attachment 390344 [details]: editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 8 2020-02-11 06:53:47 PST
The commit-queue encountered the following flaky tests while processing attachment 390344 [details]: editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 9 2020-02-11 07:13:20 PST
Comment on attachment 390344 [details] Patch Clearing flags on attachment: 390344 Committed r256304: <https://trac.webkit.org/changeset/256304>
WebKit Commit Bot
Comment 10 2020-02-11 07:13:22 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.