| Summary: | Rename VideoFullscreenLayerManager to VideoLayerManager | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Peng Liu <peng.liu6> | ||||||||
| Component: | Media | Assignee: | Peng Liu <peng.liu6> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | commit-queue, eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bug-importer, youennf | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | 207573 | ||||||||||
| Bug Blocks: | 206132 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Peng Liu
2020-02-10 13:36:15 PST
Created attachment 390294 [details]
Patch
Created attachment 390302 [details]
A clearer patch
Comment on attachment 390302 [details] A clearer patch View in context: https://bugs.webkit.org/attachment.cgi?id=390302&action=review > Source/WebCore/WebCore.xcodeproj/project.pbxproj:-846 > - 2DDE1D081F574D0E00D1A365 /* JSVRStageParameters.h in Headers */ = {isa = PBXBuildFile; fileRef = 2DDE1CF61F574BFF00D1A365 /* JSVRStageParameters.h */; }; Those are cleanup for https://trac.webkit.org/changeset/255241/webkit Comment on attachment 390302 [details] A clearer patch View in context: https://bugs.webkit.org/attachment.cgi?id=390302&action=review >> Source/WebCore/WebCore.xcodeproj/project.pbxproj:-846 >> - 2DDE1D081F574D0E00D1A365 /* JSVRStageParameters.h in Headers */ = {isa = PBXBuildFile; fileRef = 2DDE1CF61F574BFF00D1A365 /* JSVRStageParameters.h */; }; > > Those are cleanup for https://trac.webkit.org/changeset/255241/webkit Could we try to not include these changes, or as separate unreviewed changes maybe. Ditto for below. > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:328 > + std::unique_ptr<VideoLayerManagerObjC> m_videoLayerManager; We could use UniqueRef. > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h:245 > + std::unique_ptr<VideoLayerManagerObjC> m_videoLayerManager; Ditto here. Comment on attachment 390302 [details] A clearer patch View in context: https://bugs.webkit.org/attachment.cgi?id=390302&action=review >>> Source/WebCore/WebCore.xcodeproj/project.pbxproj:-846 >>> - 2DDE1D081F574D0E00D1A365 /* JSVRStageParameters.h in Headers */ = {isa = PBXBuildFile; fileRef = 2DDE1CF61F574BFF00D1A365 /* JSVRStageParameters.h */; }; >> >> Those are cleanup for https://trac.webkit.org/changeset/255241/webkit > > Could we try to not include these changes, or as separate unreviewed changes maybe. Ditto for below. Yes. It is done in webkit.org/b/207573. >> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:328 >> + std::unique_ptr<VideoLayerManagerObjC> m_videoLayerManager; > > We could use UniqueRef. Right. Will do that in webkit.org/b/207592. Created attachment 390461 [details]
patch for landing
Comment on attachment 390461 [details] patch for landing Clearing flags on attachment: 390461 Committed r256424: <https://trac.webkit.org/changeset/256424> |