Bug 207502

Summary:

Rename VideoFullscreenLayerManager to VideoLayerManager

Product:

WebKit

Reporter:

Peng Liu <peng.liu6>

Component:

Media

Assignee:

Peng Liu <peng.liu6>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

207573

Bug Blocks:

206132

Attachments:

Description	Flags
Patch	none
A clearer patch	youennf: review+
patch for landing	none

Peng Liu

Reported 2020-02-10 13:36:15 PST

Rename VideoFullscreenLayerManager to VideoLayerManager

Attachments
Patch (70.36 KB, patch) 2020-02-10 14:07 PST, Peng Liu	no flags	Details Formatted Diff Diff
A clearer patch (50.69 KB, patch) 2020-02-10 15:33 PST, Peng Liu	youennf: review+	Details Formatted Diff Diff
patch for landing (42.40 KB, patch) 2020-02-11 16:34 PST, Peng Liu	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Peng Liu

Comment 1 2020-02-10 14:07:43 PST

Created attachment 390294 [details] Patch

Peng Liu

Comment 2 2020-02-10 15:33:50 PST

Created attachment 390302 [details] A clearer patch

Peng Liu

Comment 3 2020-02-10 15:37:36 PST

Comment on attachment 390302 [details] A clearer patch View in context: https://bugs.webkit.org/attachment.cgi?id=390302&action=review > Source/WebCore/WebCore.xcodeproj/project.pbxproj:-846 > - 2DDE1D081F574D0E00D1A365 /* JSVRStageParameters.h in Headers */ = {isa = PBXBuildFile; fileRef = 2DDE1CF61F574BFF00D1A365 /* JSVRStageParameters.h */; }; Those are cleanup for https://trac.webkit.org/changeset/255241/webkit

youenn fablet

Comment 4 2020-02-11 05:29:57 PST

Comment on attachment 390302 [details] A clearer patch View in context: https://bugs.webkit.org/attachment.cgi?id=390302&action=review >> Source/WebCore/WebCore.xcodeproj/project.pbxproj:-846 >> - 2DDE1D081F574D0E00D1A365 /* JSVRStageParameters.h in Headers */ = {isa = PBXBuildFile; fileRef = 2DDE1CF61F574BFF00D1A365 /* JSVRStageParameters.h */; }; > > Those are cleanup for https://trac.webkit.org/changeset/255241/webkit Could we try to not include these changes, or as separate unreviewed changes maybe. Ditto for below. > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:328 > + std::unique_ptr<VideoLayerManagerObjC> m_videoLayerManager; We could use UniqueRef. > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h:245 > + std::unique_ptr<VideoLayerManagerObjC> m_videoLayerManager; Ditto here.

Peng Liu

Comment 5 2020-02-11 15:42:55 PST

Comment on attachment 390302 [details] A clearer patch View in context: https://bugs.webkit.org/attachment.cgi?id=390302&action=review >>> Source/WebCore/WebCore.xcodeproj/project.pbxproj:-846 >>> - 2DDE1D081F574D0E00D1A365 /* JSVRStageParameters.h in Headers */ = {isa = PBXBuildFile; fileRef = 2DDE1CF61F574BFF00D1A365 /* JSVRStageParameters.h */; }; >> >> Those are cleanup for https://trac.webkit.org/changeset/255241/webkit > > Could we try to not include these changes, or as separate unreviewed changes maybe. Ditto for below. Yes. It is done in webkit.org/b/207573. >> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:328 >> + std::unique_ptr<VideoLayerManagerObjC> m_videoLayerManager; > > We could use UniqueRef. Right. Will do that in webkit.org/b/207592.

Peng Liu

Comment 6 2020-02-11 16:34:58 PST

Created attachment 390461 [details] patch for landing

WebKit Commit Bot

Comment 7 2020-02-11 21:11:26 PST

Comment on attachment 390461 [details] patch for landing Clearing flags on attachment: 390461 Committed r256424: <https://trac.webkit.org/changeset/256424>

Radar WebKit Bug Importer

Comment 8 2020-02-12 09:32:26 PST

<rdar://problem/59389344>

Note You need to log in before you can comment on or make changes to this bug.