Bug 207498 – Adjust the minor version number for the desktop user agent string.

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[Keith Rollin]

Adjust the minor version number for the desktop user agent string.

[Keith Rollin]

<rdar://problem/59274765>

[Keith Rollin]

Created attachment 390286 [details]
Patch

[Wenson Hsieh]

Comment on attachment 390286 [details]
Patch

I filed <https://bugs.webkit.org/show_bug.cgi?id=207500> to track making this a part of a build phase.

[WebKit Commit Bot]

Comment on attachment 390286 [details]
Patch

Rejecting attachment 390286 [details] from commit-queue.

New failing tests:
editing/spelling/spellcheck-async-remove-frame.html
Full output: https://webkit-queues.webkit.org/results/13320451

[WebKit Commit Bot]

Created attachment 390305 [details]
Archive of layout-test-results from webkit-cq-01 for mac-mojave

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: webkit-cq-01  Port: mac-mojave  Platform: Mac OS X 10.14.6

[Keith Rollin]

Comment on attachment 390286 [details]
Patch

Ain't no way this change broke a Windows test.

[Chris Dumez]

Comment on attachment 390286 [details]
Patch

Clearing flags on attachment: 390286

Committed r256230: <https://trac.webkit.org/changeset/256230>

[Chris Dumez]

All reviewed patches have been landed.  Closing bug.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 390286 [details]:

editing/spelling/spellcheck-attribute.html bug 206178 (authors: [e-mail], [e-mail], and [e-mail])
The commit-queue is continuing to process your patch.

[Darin Adler]

Comment on attachment 390286 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=390286&action=review

> Source/WebCore/platform/ios/UserAgentIOS.mm:86
>          String appNameSuffix = applicationName.isEmpty() ? "" : makeString(" ", applicationName);
> -        return makeString("Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15) AppleWebKit/605.1.15 (KHTML, like Gecko)", appNameSuffix);
> +        return makeString("Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_4) AppleWebKit/605.1.15 (KHTML, like Gecko)", appNameSuffix);

Not part of this patch, but for what it’s worth, here’s a more efficient idiom for cases like this:

    const char* separator = applicationName.isEmpty() ? "" : " ";
    return makeString("Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_4) AppleWebKit/605.1.15 (KHTML, like Gecko)", separator, applicationName);

Avoids creating and destroying a temporary WTF::String.