Bug 207492

Summary:

[ews] Use SetBuildSummary instead of buildFinished in Layout tests

Product:

WebKit

Reporter:

Aakash Jain <aakash_jain>

Component:

Tools / Tests

Assignee:

Aakash Jain <aakash_jain>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, ap, jbedard, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

201934

Attachments:

Description	Flags
Patch	jbedard: review+

Aakash Jain

Reported 2020-02-10 12:12:25 PST

[ews] Use SetBuildSummary instead of buildFinished in Layout tests to set custom build summary. buildFinished() method finishes the build immediately, while it might not be desirable in some cases/factories. We added SetBuildSummary build step in https://bugs.webkit.org/show_bug.cgi?id=207026 for this purpose. We are using that for webkitpy tests. We should start using that that in layout-tests as well.

Attachments
Patch (2.99 KB, patch) 2020-02-10 12:14 PST, Aakash Jain	jbedard: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Aakash Jain

Comment 1 2020-02-10 12:14:14 PST

Created attachment 390282 [details] Patch

Aakash Jain

Comment 2 2020-02-10 12:17:08 PST

Sample runs: No failures: https://ews-build.webkit-uat.org/#/builders/16/builds/76 Flaky failures: https://ews-build.webkit-uat.org/#/builders/16/builds/80 pre-existing test failures: https://ews-build.webkit-uat.org/#/builders/16/builds/82

Aakash Jain

Comment 3 2020-02-10 13:14:42 PST

Committed r256206: <https://trac.webkit.org/changeset/256206>

Radar WebKit Bug Importer

Comment 4 2020-02-10 13:15:16 PST

<rdar://problem/59322779>

Note You need to log in before you can comment on or make changes to this bug.